fix: abort PM enforcement if the script runs in a dependency #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test it by creating a repository using NPM and try to install |
|
We are also seeing this problem on Mac, and this fix makes sense to me. |
|
Same issue here, on a github action pipeline with yarn v3.3.1. only-allow is executed when running "yarn install" on a project having a dependency containing only-allow preinstall script. |
|
@zkochan is there any concerns regarding this? I would love to see this merged. Currently I have to work around this by having: instead of just |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason why is that NPM runs the preinstall script from the cache instead of from node_modules.
One way to detect that is by testing the presence of the
_cacachewhich is the folder NPM uses for its cache.Closes #13