-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TODO List: Initial integration of pacquet's frozen-lockfile to pnpm #149
Comments
What will JSON API be used for? |
pnpm will interact with pacquet via JSON stdout. On happy path, pnpm will periodically listen to JSON messages and output report to the terminal. On error path, an appropriate JSON message will be processed by pnpm to determine if it should fallback to Node.js or print an error message. |
pnpm uses NDJSON to log data and it is used by the reporter to do pretty output for the users. So if pacquet will print the same logs, pnpm's renderer will work. |
@zkochan What about error reporting? |
Error is one of the log types https://github.com/pnpm/logger/blob/37902c06048ec4df19f6ebc11b14d1263d9f1a17/src/logger.ts#L12 |
Does For example: If { "error": { "type": "NotYetImplemented", "message": "monorepo is not yet implemented" } } |
Let's not do any fallback stuff. This is experimental. If it fails, it is fine. |
panic
when frozen-lockfile is enabled.The text was updated successfully, but these errors were encountered: