Skip to content

Commit d7f4f59

Browse files
committed
관측성 리뷰 지적 사항 수정
1 parent b7b04cf commit d7f4f59

2 files changed

Lines changed: 16 additions & 3 deletions

File tree

backend/utils/json_logging.py

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from utils.observability_context import get_request_id
66

77

8-
SENSITIVE_FIELDS = {
8+
SENSITIVE_EXACT_FIELDS = {
99
"authorization",
1010
"cookie",
1111
"password",
@@ -14,6 +14,17 @@
1414
"code",
1515
"src",
1616
}
17+
SENSITIVE_SUBSTRINGS = {
18+
"authorization",
19+
"cookie",
20+
"password",
21+
"token",
22+
"secret",
23+
"source_code",
24+
"sourcecode",
25+
"spj_code",
26+
"src",
27+
}
1728

1829

1930
class CodePlaceJsonFormatter(logging.Formatter):
@@ -56,4 +67,4 @@ def _redact(self, value):
5667
@staticmethod
5768
def _is_sensitive_key(key):
5869
normalized = str(key).lower()
59-
return any(field in normalized for field in SENSITIVE_FIELDS)
70+
return normalized in SENSITIVE_EXACT_FIELDS or any(field in normalized for field in SENSITIVE_SUBSTRINGS)

backend/utils/observability_metrics.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,11 @@ def _judge_server_metrics(self):
130130
logger.warning("Failed to collect judge-server metrics: %s", e)
131131
servers = []
132132
for server in servers:
133+
if server.is_disabled:
134+
continue
133135
hostname = server.hostname or "unknown"
134136
heartbeat_age = max((now - server.last_heartbeat).total_seconds(), 0)
135-
available = 1 if not server.is_disabled and server.status == "normal" else 0
137+
available = 1 if server.status == "normal" else 0
136138
available_metric.add_metric([hostname], available)
137139
heartbeat_metric.add_metric([hostname], heartbeat_age)
138140
task_metric.add_metric([hostname], server.task_number)

0 commit comments

Comments
 (0)