We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, I found a small issue in the code, when you have multiple windows, close one of them will delete other window's shadow map:
codesamples/bike_shadows/shadowrenderwindow.cpp
Line 19 in 985f057
The cleanup operation should be put into a slot for aboutToBeDestroyed
void ShadowRenderWindow::cleanup() { makeCurrent(); if(m_shadowMapTex > 0) glDeleteTextures(1, &m_shadowMapTex); if(m_shadowMapFBO > 0) glDeleteFramebuffers(1, &m_shadowMapFBO); doneCurrent(); } void ShadowRenderWindow::initializeGL() { connect(context(), &QOpenGLContext::aboutToBeDestroyed, this, &ShadowRenderWindow::cleanup); .... .... }
The text was updated successfully, but these errors were encountered:
Hi @huxingyi - My genuine apologies for the super late reply. I will check this out and update the code. Thank you so much for your contribution.
Sorry, something went wrong.
No branches or pull requests
Hi, I found a small issue in the code, when you have multiple windows, close one of them will delete other window's shadow map:
codesamples/bike_shadows/shadowrenderwindow.cpp
Line 19 in 985f057
The cleanup operation should be put into a slot for aboutToBeDestroyed
The text was updated successfully, but these errors were encountered: