Add period of report to filing homepage

Author: dgunning

edgar/attachments.py

@@ -628,15 +628,23 @@ def get_filers(self):
         return filer_infos
 
     @lru_cache(maxsize=None)
-    def get_filing_dates(self)-> Optional[Tuple[str,str]]:
-        # Find the div with the formGrouping class
-        form_grouping = self._soup.find("div", class_="formGrouping")
-        if form_grouping is None:
+    def get_filing_dates(self)-> Optional[Tuple[str,str, Optional[str]]]:
+        # Find the form grouping divs
+        grouping_divs = self._soup.find_all("div", class_="formGrouping")
+        if len(grouping_divs) == 0:
             return None
-        info_divs = form_grouping.find_all("div", class_="info")
+        date_grouping_div = grouping_divs[0]
+        info_divs = date_grouping_div.find_all("div", class_="info")
         filing_date = info_divs[0].text.strip()
         accepted_date = info_divs[1].text.strip()
-        return filing_date, accepted_date
+
+        if len(grouping_divs) > 1:
+            period_grouping_div = grouping_divs[1]
+            first_info_div = period_grouping_div.find("div", class_="info")
+            if first_info_div:
+                period = first_info_div.text.strip()
+                return filing_date, accepted_date, period
+        return filing_date, accepted_date, None
 
     @classmethod
     def load(cls, url: str):

tests/batch/batch_company_filings.py

@@ -0,0 +1,17 @@
+from edgar import *
+from edgar.reference.tickers import popular_us_stocks
+from tqdm.auto import tqdm
+import re
+
+
+def check_company_filings():
+    tickers = popular_us_stocks().sample(20).Ticker.tolist()
+    for ticker in tqdm(tickers):
+        company = Company(ticker)
+        for filing in tqdm(company.filings):
+            print(filing.acceptance_datetime)
+
+
+
+if __name__ == '__main__':
+    check_company_filings()

tests/batch/batch_filing_dates.py

@@ -0,0 +1,21 @@
+from edgar import *
+from tqdm.auto import tqdm
+import re
+
+
+def check_filing_dates():
+    filings = get_filings(year=[2012,2020,2024]).sample(40)
+    for filing in tqdm(filings):
+        homepage = filing.homepage
+        filing_date, acceptance_datetime, period_of_report = homepage.get_filing_dates()
+        print(period_of_report)
+        assert period_of_report is None or re.match('\d{4}-\d{2}-\d{2}', filing_date),\
+            f"Invalid period of report {period_of_report} for {filing}"
+
+
+
+if __name__ == '__main__':
+    check_filing_dates()
+
+
+

tests/test_filing_metadata.py

@@ -0,0 +1,7 @@
+from edgar import Filing, FilingHomepage
+
+def test_get_filing_period_from_homepage():
+    f = Filing(company='VISA INC.', cik=1403161, form='4', filing_date='2025-01-03', accession_no='0001127602-25-000445')
+    home = f.homepage
+    filing_date, acceptance, period = home.get_filing_dates()
+    assert (filing_date, acceptance, period) == ('2025-01-03', '2025-01-03 16:28:38', '2025-01-02')