Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ: What is new with session rollovers in RC 0.10.4? #1577

Open
7 tasks
Olshansk opened this issue Aug 2, 2023 · 5 comments
Open
7 tasks

FAQ: What is new with session rollovers in RC 0.10.4? #1577

Olshansk opened this issue Aug 2, 2023 · 5 comments
Assignees
Labels
Milestone

Comments

@Olshansk
Copy link
Member

Olshansk commented Aug 2, 2023

Objective

Follow up on the session rollover feature from RC 0.10.

Origin Document

Goals

  • Gain insight into session rollover adoption
  • Understand to what degree Session Rollover eliminate the need of altruists
  • Educate the node runners on how/why to enable session rollovers

Deliverable

  • 1. Work with the portal backend/infra team to collect analytics on how altruists are being used (cc @kutoft @fredteumer)
  • 2. Send out a survey to all node runners to understand what value everyone has set client_session_sync_allowance to in their configurations
  • 3. Put together a 1 pager on what node runners should set client_session_sync_allowance to in order to enable session rollover
    • Optional: 3.1 Work with the poktpool team to translate this into an infographic
    1. After all of the above are done:
    • 4.1 Spearhead adoption of client_session_sync_allowance from 0 to 1
    • 4.2 Track the impact of (4.1) on (1) as adoption increases
    • 4.3 Evaluate the network cost savings (see pip-28) based on the result of (4.2)

Non-goals / Non-deliverables

  • Implementing new features or business logic
  • Forcing all node runners to adopt session rollovers
  • Eliminating the need for altruists

Creator: @Olshansk
Co-Owners: @RossiNYC

@Olshansk Olshansk added the FAQ label Aug 2, 2023
@Olshansk Olshansk added this to the Network Cost milestone Aug 2, 2023
@RossiNYC
Copy link

RossiNYC commented Aug 3, 2023

@Olshansk - is there a way to proactively view this and other parameters/settings w/o having to survey node runners directly?

Send out a survey to all node runners to understand what value everyone has set client_session_sync_allowance to in their configurations

@Olshansk
Copy link
Member Author

Olshansk commented Aug 3, 2023

is there a way to proactively view this and other parameters/settings w/o having to survey node runners directly?

tl;dr No - not to my knowledge.


Extra Unecessary Details & Investigation

Governance Params

I was able to query governance params like so

export POCKET_ENDPOINT=https://mainnet.gateway.pokt.network/v1/lb/60a2ac11b1747c6552385c61
pocket query params --remoteCLIURL ${POCKET_ENDPOINT}

Which gives:

{
    "app_params": [
        {
            "param_key": "application/MaximumChains",
            "param_value": "15"
        },
        ...

But this does not give node configurations....

Tendermint Status / Configs

Since these are Tendermint level configurations, I tried to, I tried to query the status of the Tendermint notes on TesetNet provided by the NodeFleet team (cc @StevenMartinez94 @aqt01) like so:

curl -S "https://testnet:${NODE_FLEET_PASSWORD}@node1.tendermint.testnet.pokt.network/status"

But this does not show node-specific configurations:

{
  "jsonrpc": "2.0",
  "id": -1,
  "result": {
    "node_info": {
      "protocol_version": {
        "p2p": "7",
        "block": "10",
        "app": "0"
      },
      "id": "77e608d8ae4cd7b812f122dc82537e79dd3565cb",
      "listen_addr": "tcp://86.48.21.90:26662",
      "network": "testnet",
      "version": "0.33.8",
      "channels": "4020212223303800",
      "moniker": "testnet-12",
      "other": {
        "tx_index": "on",
        "rpc_address": "tcp://0.0.0.0:26657"
      }
    },
    "sync_info": {
      "latest_block_hash": "9501F2C0A01C80C99B678A9D4B085439D6AAA55D69BAC8FAD0F4E6E02C6502E4",
      "latest_app_hash": "29DAB7A057F099C0F813ACBFC0CAB7654298409F3C3C0241F7164F21F633E812",
      "latest_block_height": "113790"

Node Configs

I ended up asking ChatGPT if it is aware of a way to query node-specific configurations (i.e. the off-chain, non-governance, node specific configs) and it also told me there's no way:

Screenshot 2023-08-03 at 11 34 11 AM


In short, unless the whole network (and forks) adopts a software change that exposes a new endpoint to expose this, I'm personally not aware of a way to do this.

@Olshansk
Copy link
Member Author

Olshansk commented Aug 8, 2023

@RossiNYC I wanted to know:

  1. Was the context above sufficient?
  2. Any progress on this issue?
  3. Any blockers or support you need on this?

@RossiNYC
Copy link

RossiNYC commented Aug 8, 2023

@Olshansk - set up call with @fredteumer & @kutoft for tomorrow afternoon, there was some concern in the last PNF All Hands around over-surveying so I was going to bring this up tomorrow morning on the next call which is why I was asking if the data was available proactively - I'm sure we can get the info, will get feedback/greenlight from them tomorrow (unless I confused a few things here and this isn't the proper process?) Let me know if I am over thinking it!

@Olshansk
Copy link
Member Author

Olshansk commented Aug 9, 2023

@Olshansk - set up call with @fredteumer & @kutoft for tomorrow afternoon, there was some concern in the last PNF All Hands around over-surveying so I was going to bring this up tomorrow morning on the next call which is why I was asking if the data was available proactively - I'm sure we can get the info, will get feedback/greenlight from them tomorrow (unless I confused a few things here and this isn't the proper process?) Let me know if I am over thinking it!

Sounds like a great plan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Up Next
Development

No branches or pull requests

2 participants