From 80ac2e420993bb8f0ddcdb24a6d03af77c601044 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bastian=20K=C3=B6cher?= <git@kchr.de>
Date: Wed, 8 Jan 2025 23:33:07 +0100
Subject: [PATCH] Let the entire job fail when one strategy fails (#529)

Before the entire job counted as success, even with individual
strategies failing.

<!-- Remember that you can run `/merge` to enable auto-merge in the PR
-->

<!-- Remember to modify the changelog. If you don't need to modify it,
you can check the following box.
Instead, if you have already modified it, simply delete the following
line. -->

- [x] Does not require a CHANGELOG entry

---------

Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
---
 .github/workflows/check-migrations.yml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/check-migrations.yml b/.github/workflows/check-migrations.yml
index 968ff80c00..948ae5bf10 100644
--- a/.github/workflows/check-migrations.yml
+++ b/.github/workflows/check-migrations.yml
@@ -44,9 +44,10 @@ jobs:
   # if they all pass, that job will pass too.
   check-migrations:
     needs: [runtime-matrix]
-    continue-on-error: true
     runs-on: ubuntu-latest
     strategy:
+      # Ensure the other jobs continue
+      fail-fast: false
       matrix:
         runtime: ${{ fromJSON(needs.runtime-matrix.outputs.runtime) }}
     steps: