Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify duplicated code and merge them #336

Open
xlc opened this issue May 30, 2024 · 1 comment
Open

Identify duplicated code and merge them #336

xlc opened this issue May 30, 2024 · 1 comment

Comments

@xlc
Copy link
Contributor

xlc commented May 30, 2024

          I found there are too many duplicated code for a new system parachain. This is a code smell and should be addressed at some stage. We will have more system parachains and we need to reduce the overhead of making one before making more system parachains.

Originally posted by @xlc in #319 (review)

@joepetrowski
Copy link
Contributor

There isn't very much overhead, can set up a new one in a morning. Feel free to make a PR but we (Parity) have already had a lot of people restructure code to have less duplication where it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants