Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove emulated test macros #363

Open
ggwpez opened this issue Jun 26, 2024 · 3 comments
Open

Remove emulated test macros #363

ggwpez opened this issue Jun 26, 2024 · 3 comments

Comments

@ggwpez
Copy link
Member

ggwpez commented Jun 26, 2024

TODO from here:

runtimes/integration-tests/emulated/helpers/src/lib.rs

Lines 31 to 33 in 8ec28f9

/// TODO: when bumping to polkadot-sdk v1.8.0,
/// remove this crate altogether and get the macros from `emulated-integration-tests-common`.
/// TODO: backport this macros to polkadot-sdk

cc @bkontur
@ggwpez ggwpez mentioned this issue Jun 26, 2024
Merged
4 tasks
@bkontur bkontur mentioned this issue Jun 26, 2024
Open
4 tasks
@bkontur
Copy link
Contributor

bkontur commented Jun 26, 2024

yes, I have also TODO here,

  • remove helpers module from inegrations-tests and re-use from polkadot-sdk

We need to move those macros into the polkadot-sdk first. For example, macro_rules! test_chain_can_claim_assets and the test case for claiming assets are not even implemented in polkadot-sdk.

If we want to fix this for version 1.13, we would need to backport it to both 1.13 and 1.14.

So, I would say this is not a high priority and we can live with this TODO for now. The tests are working for fellows, which is important. We will eventually fix this here: #4892 (good first issue or for whoever wants to contribute).

@bkontur bkontur mentioned this issue Jun 26, 2024
Closed
9 tasks
@ggwpez
Copy link
Member Author

ggwpez commented Jun 26, 2024

So, I would say this is not a high priority and we can live with this TODO for now

Yes for sure. I just like to open issues for TODOs in the code 😄 so that we dont forget them.

Merged
4 tasks
@programskillforverification
Copy link

@bkontur I already move all macros into the polkadot-sdk. Once you remove macro, the third task in Backport integration tests for claim assets to the polkadot-sdk from polkadot-fellows repo #4892 can be done.

github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this issue Jul 19, 2024
@programskillforverification @acatangiu @franciscoaguirre
Backport claim assets tests from polkadot-fellows repo (#4930)
d16af0b 
# Issue
[Backport integration tests for claim assets to the polkadot-sdk from
polkadot-fellows repo
#4892](#4892)
# Description
For the first time to contribute this project, I just finished part and
make sure everything is ok.
- [x] backport [claim_assets test
case](https://github.com/polkadot-fellows/runtimes/blob/main/integration-tests/emulated/tests/assets/asset-hub-kusama/src/tests/claim_assets.rs)
to the polkadot-sdk testnet integration tests
- [x] backport macro
[test_chain_can_claim_assets](https://github.com/polkadot-fellows/runtimes/blob/main/integration-tests/emulated/helpers/src/lib.rs#L218)
from fellows repo
- [ ] when merged to polkadot-sdk and released, make sure that it is
propagated to the fellows repo:
polkadot-fellows/runtimes#363
- [x] backport and align other macros/test-cases from
https://github.com/polkadot-fellows/runtimes/blob/8ec28f96eeb30fbba30d29006d75e1a3fa1cea1c/integration-tests/emulated/helpers/src/lib.rs#L31-L33

---------

Co-authored-by: Zihan Zhao <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Adrian Catangiu <[email protected]>
Co-authored-by: Francisco Aguirre <[email protected]>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
@programskillforverification @acatangiu
@franciscoaguirre @TarekkMA
Backport claim assets tests from polkadot-fellows repo (paritytech#4930)
9c35ad4 
# Issue
[Backport integration tests for claim assets to the polkadot-sdk from
polkadot-fellows repo
paritytech#4892](paritytech#4892)
# Description
For the first time to contribute this project, I just finished part and
make sure everything is ok.
- [x] backport [claim_assets test
case](https://github.com/polkadot-fellows/runtimes/blob/main/integration-tests/emulated/tests/assets/asset-hub-kusama/src/tests/claim_assets.rs)
to the polkadot-sdk testnet integration tests
- [x] backport macro
[test_chain_can_claim_assets](https://github.com/polkadot-fellows/runtimes/blob/main/integration-tests/emulated/helpers/src/lib.rs#L218)
from fellows repo
- [ ] when merged to polkadot-sdk and released, make sure that it is
propagated to the fellows repo:
polkadot-fellows/runtimes#363
- [x] backport and align other macros/test-cases from
https://github.com/polkadot-fellows/runtimes/blob/8ec28f96eeb30fbba30d29006d75e1a3fa1cea1c/integration-tests/emulated/helpers/src/lib.rs#L31-L33

---------

Co-authored-by: Zihan Zhao <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Adrian Catangiu <[email protected]>
Co-authored-by: Francisco Aguirre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bkontur @ggwpez @programskillforverification