-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
investigate errors when skipping xcm benchmarks for collectives-polkadot #446
Comments
brenzi
changed the title
investigate errors when skipping xcm benchmarks
investigate errors when skipping xcm benchmarks for collectives-polkadot
Aug 23, 2024
bkontur
added a commit
to bkontur/runtimes
that referenced
this issue
Jan 16, 2025
1 task
Will be fixed by: #547 |
fellowship-merge-bot bot
pushed a commit
that referenced
this issue
Jan 24, 2025
Closes: paritytech/polkadot-sdk#2904 Closes: #446 Continuation: paritytech/polkadot-sdk#6820 The `collectives-polkadot` uses `FixedWeightBounds`. This PR introduces a properly measured XCM benchmarking setup and updates the weights with fresh data. ## TODO - [x] check if we use somewhere some hard-coded weights for `Transact` that goes to the `collectives-polkadot` --------- Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Muharem <[email protected]>
@brenzi can you please close this? It is merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While fixing XCM benchmarking for encointer in #440, I got an error while running xcm::generic benchmarks:
https://gist.github.com/brenzi/bb6050f9cb00d34f279cf1f4e5b6e4ba
I did
and got
Error executing and verifying runtime benchmark: Benchmark not found for this pallet.
This error should be ignored because the benchmark is skipped for our runtime, as this functionality isn't provided by encointer (exactly like people chain for example).
I relalized that a check needs to be removed and that the coretime chain still has this check implemented. I guess it should be removed too?
runtimes/system-parachains/collectives/collectives-polkadot/src/lib.rs
Line 1164 in 790ef91
The text was updated successfully, but these errors were encountered: