Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No typescript support for websockets #167

Open
KevinEdry opened this issue Jun 24, 2023 · 1 comment
Open

No typescript support for websockets #167

KevinEdry opened this issue Jun 24, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@KevinEdry
Copy link

Hey, I've recently tried to switch to your client to handle my WebSockets connections (previously implemented in ws) and I've notice a lack of types for that api.

I was wondering if this is intentional? I was looking for types to the different messages, maybe a union based on the ev parameter.
Is this something you would be interested in?

@timetraveler328 timetraveler328 added the enhancement New feature or request label Aug 11, 2023
@timetraveler328
Copy link
Collaborator

Hey @KevinEdry, this is definitely something that would be very useful. I think a union type could accomplish it without too much trouble. I'll put it on our feature list, but you're welcome to put in a PR as well. Thanks for filing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants