Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved domain name resolution, domain lookup page, and domain transfer page #197

Open
polymorpher opened this issue Nov 25, 2021 · 2 comments
Assignees
Labels
good first issue Good for newcomers ui

Comments

@polymorpher
Copy link
Owner

Currently, domain resolution is automatically performed in address input box:

https://github.com/polymorpher/one-wallet/blob/master/code/client/src/components/AddressInput.jsx

However, a lot of people are unaware of that. A placeholder, or some hint texts around the input box should be added to inform people that domains can be used.

When domains are typed in, the resolution is not intelligent. If the input domain has no ., it should automatically attempt to resolve the domain with .crazy.one suffix. If full domains are being entered, it should append just sufficient amount of suffix intelligently.

It should also auto-complete on known domains in the address book.

There should also be a dedicated page where people can type in an address and find out whether it resolves to a wallet address (hex or one1), and whether the address corresponds to a 1wallet. Similarly, if an address is provided, it should be resolved to a domain.

Domain transfer functionalities were already implemented, but not displayed in UI at the moment. Some testing, bug fixes and visual realignment might be required:
https://github.com/polymorpher/one-wallet/blob/master/code/client/src/pages/Show/TransferDomain.jsx

When users purchase new domains, sometimes they use a . in the domain name, thinking that they can use multiple layers of subdomains. This is technically supported on-chain but it messes up the namehash algorithm, therefore it doesn't really work unless we only resolve for crazy.one domains. Therefore, we should add an input filter and validate/transform the domain name before allowing the user to purchase it. See also #169

Lastly, we should add a tool that allow people with existing ownership of a [subdomain].crazy.one domain under their MetaMask wallet to transfer the ownership from their MetaMask wallet to their 1wallet. See also #126 and #156

@polymorpher polymorpher added good first issue Good for newcomers ui labels Nov 25, 2021
@cylim cylim self-assigned this Dec 23, 2021
@cylim
Copy link
Collaborator

cylim commented Dec 23, 2021

@polymorpher
Some Questions,

  1. About purchase new domains, any other domains supported other than crazy.one?
  2. Transfer Ownership: Not sure how this is done, crazy.one website doesn't have the feature yet (or not accesible by end user). If we want to do it in 1wallet, that's mean we need to integrate with metamask, and calling the crazyone contract from metamask?

@polymorpher
Copy link
Owner Author

We already implemented ownership transfer on both the wallet contract and the frontend. See doTransferDomain in TransferDomain.jsx. Purchasing arbitrary domain is also supported on wallet contract and core apis, but the frontend implementation is already done (using constant variables specific for crazy.one for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ui
Projects
None yet
Development

No branches or pull requests

2 participants