python.d.plugin update (netdata#4936)

<!--
Describe the change in summary section, including rationale and degin decisions.
Include "Fixes #nnn" if you are fixing an existing issue.

In "Component Name" section write which component is changed in this PR. This
will help us review your PR quicker.

If you have more information you want to add, write them in "Additional
Information" section. This is usually used to help others understand your
motivation behind this change. A step-by-step reproduction of the problem is
helpful if there is no related issue.
-->

##### Summary
Fix: netdata#4756

`python.d.plugin` updates:
  * remove `retries` option 
  * make `penalty` configurable (enabled by default, max is 10 minutes)

> penalty indicates whether to apply penalty to update_every in case of failures.
> Penalty will increase every 5 failed updates in a row. Maximum penalty is 10 minutes.
> penalty: yes

##### Component Name

`python.d.plugin`

##### Additional Information

Author: ilyam8

collectors/python.d.plugin/README.md

@@ -21,7 +21,6 @@ Every configuration file must have one of two formats:
 
 ```yaml
 update_every : 2 # update frequency
-retries      : 1 # how many failures in update() is tolerated
 priority     : 20000 # where it is shown on dashboard
 
 other_var1   : bla  # variables passed to module
@@ -33,7 +32,6 @@ other_var2   : alb
 ```yaml
 # module defaults:
 update_every : 2
-retries      : 1
 priority     : 20000
 
 local:  # job name
@@ -42,11 +40,10 @@ local:  # job name
 
 other_job:
   priority     : 5 # job position on dashboard
-  retries      : 20 # job retries
   other_var2   : val # module specific variable
 ```
 
-`update_every`, `retries`, and `priority` are always optional.
+`update_every` and `priority` are always optional.
 
 ## How to debug a python module
 

collectors/python.d.plugin/adaptec_raid/adaptec_raid.conf

@@ -19,11 +19,9 @@
 # If unset, the default for python.d.plugin is used.
 # priority: 60000
 
-# retries sets the number of retries to be made in case of failures.
-# If unset, the default for python.d.plugin is used.
-# Attempts to restore the service are made once every update_every
-# and only if the module has collected values in the past.
-# retries: 60
+# penalty indicates whether to apply penalty to update_every in case of failures.
+# Penalty will increase every 5 failed updates in a row. Maximum penalty is 10 minutes.
+# penalty: yes
 
 # autodetection_retry sets the job re-check interval in seconds.
 # The job is not deleted if check fails.
@@ -50,6 +48,6 @@
 #                             # JOBs sharing a name are mutually exclusive
 #     update_every: 1         # the JOB's data collection frequency
 #     priority: 60000         # the JOB's order on the dashboard
-#     retries: 60             # the JOB's number of restoration attempts
+#     penalty: yes            # the JOB's penalty
 #     autodetection_retry: 0  # the JOB's re-check interval in seconds
 # ----------------------------------------------------------------------

collectors/python.d.plugin/apache/README.md

@@ -46,12 +46,10 @@ priority     : 90100
 
 local:
   url      : 'http://localhost/server-status?auto'
-  retries  : 20
 
 remote:
   url          : 'http://www.apache.org/server-status?auto'
   update_every : 5
-  retries      : 4
 ```
 
 Without configuration, module attempts to connect to `http://localhost/server-status?auto`

collectors/python.d.plugin/apache/apache.chart.py

@@ -8,7 +8,6 @@
 # default module values (can be overridden per job in `config`)
 # update_every = 2
 priority = 60000
-retries = 60
 
 # default job configuration (overridden by python.d.plugin)
 # config = {'local': {

collectors/python.d.plugin/apache/apache.conf

@@ -27,11 +27,9 @@
 # If unset, the default for python.d.plugin is used.
 # priority: 60000
 
-# retries sets the number of retries to be made in case of failures.
-# If unset, the default for python.d.plugin is used.
-# Attempts to restore the service are made once every update_every
-# and only if the module has collected values in the past.
-# retries: 60
+# penalty indicates whether to apply penalty to update_every in case of failures.
+# Penalty will increase every 5 failed updates in a row. Maximum penalty is 10 minutes.
+# penalty: yes
 
 # autodetection_retry sets the job re-check interval in seconds.
 # The job is not deleted if check fails.
@@ -58,7 +56,7 @@
 #                             # JOBs sharing a name are mutually exclusive
 #     update_every: 1         # the JOB's data collection frequency
 #     priority: 60000         # the JOB's order on the dashboard
-#     retries: 60             # the JOB's number of restoration attempts
+#     penalty: yes            # the JOB's penalty
 #     autodetection_retry: 0  # the JOB's re-check interval in seconds
 #
 # Additionally to the above, apache also supports the following:

collectors/python.d.plugin/beanstalk/beanstalk.chart.py

@@ -15,7 +15,6 @@
 # default module values (can be overridden per job in `config`)
 # update_every = 2
 priority = 60000
-retries = 60
 
 ORDER = ['cpu_usage', 'jobs_rate', 'connections_rate', 'commands_rate', 'current_tubes', 'current_jobs',
          'current_connections', 'binlog', 'uptime']

collectors/python.d.plugin/beanstalk/beanstalk.conf

@@ -27,11 +27,9 @@
 # If unset, the default for python.d.plugin is used.
 # priority: 60000
 
-# retries sets the number of retries to be made in case of failures.
-# If unset, the default for python.d.plugin is used.
-# Attempts to restore the service are made once every update_every
-# and only if the module has collected values in the past.
-# retries: 60
+# penalty indicates whether to apply penalty to update_every in case of failures.
+# Penalty will increase every 5 failed updates in a row. Maximum penalty is 10 minutes.
+# penalty: yes
 
 # autodetection_retry sets the job re-check interval in seconds.
 # The job is not deleted if check fails.
@@ -68,7 +66,7 @@
 #                             # JOBs sharing a name are mutually exclusive
 #     update_every: 1         # the JOB's data collection frequency
 #     priority: 60000         # the JOB's order on the dashboard
-#     retries: 60             # the JOB's number of restoration attempts
+#     penalty: yes            # the JOB's penalty
 #     autodetection_retry: 0  # the JOB's re-check interval in seconds
 #     chart_cleanup: 10       # the JOB's chart cleanup interval in iterations
 #

collectors/python.d.plugin/bind_rndc/bind_rndc.chart.py

@@ -12,7 +12,6 @@
 from bases.FrameworkServices.SimpleService import SimpleService
 
 priority = 60000
-retries = 60
 update_every = 30
 
 ORDER = ['name_server_statistics', 'incoming_queries', 'outgoing_queries', 'named_stats_size']

collectors/python.d.plugin/bind_rndc/bind_rndc.conf

@@ -27,11 +27,9 @@
 # If unset, the default for python.d.plugin is used.
 # priority: 60000
 
-# retries sets the number of retries to be made in case of failures.
-# If unset, the default for python.d.plugin is used.
-# Attempts to restore the service are made once every update_every
-# and only if the module has collected values in the past.
-# retries: 60
+# penalty indicates whether to apply penalty to update_every in case of failures.
+# Penalty will increase every 5 failed updates in a row. Maximum penalty is 10 minutes.
+# penalty: yes
 
 # autodetection_retry sets the job re-check interval in seconds.
 # The job is not deleted if check fails.
@@ -58,7 +56,7 @@
 #                             # JOBs sharing a name are mutually exclusive
 #     update_every: 1         # the JOB's data collection frequency
 #     priority: 60000         # the JOB's order on the dashboard
-#     retries: 60             # the JOB's number of restoration attempts
+#     penalty: yes            # the JOB's penalty
 #     autodetection_retry: 0  # the JOB's re-check interval in seconds
 #
 # Additionally to the above, bind_rndc also supports the following:

collectors/python.d.plugin/boinc/boinc.conf

@@ -27,11 +27,9 @@
 # If unset, the default for python.d.plugin is used.
 # priority: 60000
 
-# retries sets the number of retries to be made in case of failures.
-# If unset, the default for python.d.plugin is used.
-# Attempts to restore the service are made once every update_every
-# and only if the module has collected values in the past.
-# retries: 60
+# penalty indicates whether to apply penalty to update_every in case of failures.
+# Penalty will increase every 5 failed updates in a row. Maximum penalty is 10 minutes.
+# penalty: yes
 
 # autodetection_retry sets the job re-check interval in seconds.
 # The job is not deleted if check fails.
@@ -58,7 +56,7 @@
 #                             # JOBs sharing a name are mutually exclusive
 #     update_every: 1         # the JOB's data collection frequency
 #     priority: 60000         # the JOB's order on the dashboard
-#     retries: 60             # the JOB's number of restoration attempts
+#     penalty: yes            # the JOB's penalty
 #     autodetection_retry: 0  # the JOB's re-check interval in seconds
 #
 # Additionally to the above, boinc also supports the following: