Miscelaneous config fixes & PPL rewording #2002
Conversation
✅ Deploy Preview for pomerium-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
alexandreLamarre
changed the title
alexandreLamarre
requested review from
kenjenkins
and removed request for
a team
| Criteria in PPL are represented as an object where the key is the name and optional sub-path of the criterion, and the value changes depending on which criterion is used. | ||
| In PPL, a criterion defines a specific condition to evaluate, such as a user’s email or device type. | ||
|
|
||
| - Each criterion is an object where the key is the criterion name (optionally with a sub-path, delimited by `/`), and the value specifies what to match or compare. |
There was a problem hiding this comment.
I wonder if we should aim to avoid duplication between this page and the main PPL reference page. Would it be better to condense some of this information here? Looks like there is already a link to the main PPL page below.
(Up to you, no strong preference from me.)
There was a problem hiding this comment.
I looked into deduplicating this by defining shared content somewhere and embedding it in each page, but I couldn't find any handy mechanisms to do so with our current docusaurus setup.
I think we should keep it this way for now, because the /internals page is a full reference and the I'm wary of throwing just a link to the full reference in a getting started guide
There was a problem hiding this comment.
Just FYI— Docusaurus does offer an "import" feature for snippets of markdown, see https://docusaurus.io/docs/markdown-features/react#importing-markdown.
alexandreLamarre
force-pushed
the
misc-fixes-alex
branch
from
8e2475f to
6be08b1
Compare
ssh_user_ca_key_fileis a string, not an array.