fix(build): TypeScript compiler errors were not being shown or caught

Author: mmstick

Makefile

@@ -35,7 +35,7 @@ configure:
 	sh scripts/configure.sh
 
 compile: $(sources) clean
-	env PROJECTS="$(PROJECTS)" sh scripts/transpile.sh
+	env PROJECTS="$(PROJECTS)" ./scripts/transpile.sh
 
 # Rebuild, install, reconfigure local settings, restart shell, and listen to journalctl logs
 debug: depcheck compile install install-system76-plugins configure enable restart-shell listen

scripts/transpile.sh

@@ -21,10 +21,10 @@ glib-compile-schemas schemas &
 
 for proj in ${PROJECTS}; do
     mkdir -p _build/${proj}
-    tsc --p src/${proj} &
+    tsc --p src/${proj}
 done
 
-tsc &
+tsc
 
 wait
 
@@ -34,7 +34,7 @@ cp -r metadata.json icons schemas *.css _build &
 
 for src in $(find target -name '*.js'); do
     dest=$(echo $src | sed s#target#_build#g)
-    transpile &
+    transpile
 done
 
 wait

src/extension.ts

@@ -170,9 +170,6 @@ export class Ext extends Ecs.System<ExtEvent> {
 
     private size_requests: Map<GObject.Object, SignalID> = new Map();
 
-    /** Used to debounce on_focus triggers */
-    private focus_trigger: null | SignalID = null;
-
     // Entity-component associations
 
     /** Store for stable sequences of each registered window */
@@ -2582,7 +2579,7 @@ function _show_skip_taskbar_windows(ext: Ext) {
                         // are skip taskbar true
                         (meta_win.get_wm_class() !== null &&
                          !gnome_shell_wm_class) ||
-                    default_isoverviewwindow_ws(win);
+                    default_isoverviewwindow_ws(win));
             };
         }
     }

src/panel_settings.ts

@@ -1,10 +1,7 @@
 const Me = imports.misc.extensionUtils.getCurrentExtension();
 
-// import * as auto_tiler from 'auto_tiler';
 import * as Utils from 'utils';
-import { Launcher } from './dialog_launcher';
 
-//import type { Entity } from './ecs';
 import type { Ext } from './extension';
 
 const { Clutter, Gio, St } = imports.gi;

src/window.ts

@@ -253,8 +253,14 @@ export class ShellWindow {
     }
 
     is_single_max_screen(): boolean {
-        let monitor_count = this.meta.get_display().get_n_monitors();
-        return (this.is_maximized() || this.smart_gapped) && monitor_count == 1;
+        const display = this.meta.get_display()
+
+        if (display) {
+            let monitor_count = display.get_n_monitors();
+            return (this.is_maximized() || this.smart_gapped) && monitor_count == 1;
+        }
+
+        return false
     }
 
     is_snap_edge(): boolean {
@@ -435,8 +441,8 @@ export class ShellWindow {
      */
     restack(updateState: RESTACK_STATE = RESTACK_STATE.NORMAL) {
         this.update_border_layout();
-        if (this.meta.is_fullscreen() || 
-            (this.is_single_max_screen() && !this.is_snap_edge()) || 
+        if (this.meta.is_fullscreen() ||
+            (this.is_single_max_screen() && !this.is_snap_edge()) ||
             this.meta.minimized) {
             this.hide_border()
         }