Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop-launcher crashes gnome shell 45.4 #1707

Open
n6v26r opened this issue Mar 27, 2024 · 14 comments
Open

Pop-launcher crashes gnome shell 45.4 #1707

n6v26r opened this issue Mar 27, 2024 · 14 comments
Labels
GNOME 45 Issues using the extension on GNOME 45.

Comments

@n6v26r
Copy link

n6v26r commented Mar 27, 2024

(1) Issue/Bug Description:
When launching pop-launcher and typing text, gnome shell crashes, with the "Oh no, something has gone wrong message"

journalctl -b /usr/bin/gnome-shell reveals:

mar 27 15:10:31 manjaro gnome-shell[3611]: pop-shell: [DEBUG] starting pop-launcher service
mar 27 15:10:31 manjaro gnome-shell[3611]: ../mutter/clutter/clutter/clutter-actor.c:8798: Actor '<unnamed>[<StScrollBar>:0x562add8124a0]' tried to allocate a size of 12,00 x -12,00
mar 27 15:10:31 manjaro gnome-shell[3611]: Can't update stage views actor <unnamed>[<StBoxLayout>:0x562add80d9b0] is on because it needs an allocation.
mar 27 15:10:31 manjaro gnome-shell[3611]: Can't update stage views actor <unnamed>[<StButton>:0x562adf2a54a0] is on because it needs an allocation.
mar 27 15:10:31 manjaro gnome-shell[3611]: Can't update stage views actor <unnamed>[<StBoxLayout>:0x562ae0353580] is on because it needs an allocation.
mar 27 15:10:31 manjaro gnome-shell[3611]: Can't update stage views actor <unnamed>[<StIcon>:0x562ad5668420] is on because it needs an allocation.
mar 27 15:10:31 manjaro gnome-shell[3611]: Can't update stage views actor <unnamed>[<ClutterActor>:0x562adbbc5100] is on because it needs an allocation.
mar 27 15:10:31 manjaro gnome-shell[3611]: Can't update stage views actor <unnamed>[<StIcon>:0x562adc244830] is on because it needs an allocation.
mar 27 15:10:31 manjaro gnome-shell[3611]: Can't update stage views actor <unnamed>[<ClutterActor>:0x562add433930] is on because it needs an allocation.
mar 27 15:10:31 manjaro gnome-shell[3611]: Can't update stage views actor <unnamed>[<StBoxLayout>:0x562ade784d00] is on because it needs an allocation.
mar 27 15:10:31 manjaro gnome-shell[3611]: Can't update stage views actor <unnamed>[<StLabel>:0x562ad56eadd0] is on because it needs an allocation.
mar 27 15:10:31 manjaro gnome-shell[3611]: Can't update stage views actor <unnamed>[<ClutterText>:0x562adfbb4c60] is on because it needs an allocation.
mar 27 15:10:31 manjaro gnome-shell[3611]: Can't update stage views actor <unnamed>[<StLabel>:0x562adf148ab0] is on because it needs an allocation.
mar 27 15:10:31 manjaro gnome-shell[3611]: Can't update stage views actor <unnamed>[<ClutterText>:0x562adf11fc70] is on because it needs an allocation.
mar 27 15:10:31 manjaro gnome-shell[3611]: Can't update stage views actor <unnamed>[<StLabel>:0x562adb9714f0] is on because it needs an allocation.
mar 27 15:10:31 manjaro gnome-shell[3611]: Can't update stage views actor <unnamed>[<ClutterText>:0x562addda1780] is on because it needs an allocation.
mar 27 15:10:31 manjaro gnome-shell[3611]: cogl_framebuffer_set_viewport: assertion 'width > 0 && height > 0' failed
mar 27 15:10:31 manjaro gnome-shell[3611]: cogl_framebuffer_set_viewport: assertion 'width > 0 && height > 0' failed
mar 27 15:10:31 manjaro gnome-shell[3611]: cogl_framebuffer_set_viewport: assertion 'width > 0 && height > 0' failed
mar 27 15:10:31 manjaro gnome-shell[3611]: cogl_framebuffer_set_viewport: assertion 'width > 0 && height > 0' failed
mar 27 15:10:31 manjaro gnome-shell[3611]: cogl_framebuffer_set_viewport: assertion 'width > 0 && height > 0' failed
mar 27 15:10:31 manjaro gnome-shell[3611]: cogl_framebuffer_set_viewport: assertion 'width > 0 && height > 0' failed
mar 27 15:10:32 manjaro gnome-shell[3611]: **
mar 27 15:10:32 manjaro gnome-shell[3611]: Clutter:ERROR:../mutter/clutter/clutter/clutter-actor.c:5476:clutter_actor_dispose: assertion failed: (priv->parent == NULL)
mar 27 15:10:32 manjaro gnome-shell[3611]: Bail out! Clutter:ERROR:../mutter/clutter/clutter/clutter-actor.c:5476:clutter_actor_dispose: assertion failed: (priv->parent == NULL)
mar 27 15:10:32 manjaro gnome-shell[3611]: == Stack trace for context 0x562ad4329940 ==
mar 27 15:10:32 manjaro gnome-shell[3611]: #0   562ad43efa60 i   file:///usr/share/gnome-shell/extensions/[email protected]/search.js:205 (25f916d606f0 @ 112)
mar 27 15:10:32 manjaro gnome-shell[3611]: #1   562ad43ef9b0 i   file:///usr/share/gnome-shell/extensions/[email protected]/search.js:306 (25f916d60b00 @ 367)
mar 27 15:10:32 manjaro gnome-shell[3611]: #2   562ad43ef8d8 i   file:///usr/share/gnome-shell/extensions/[email protected]/launcher.js:116 (25f916d5dbf0 @ 273)
mar 27 15:10:32 manjaro gnome-shell[3611]: #3   562ad43ef848 i   resource:///org/gnome/shell/ui/init.js:21 (351d06470ba0 @ 48)

(2) Steps to reproduce (if you know):
Just launch pop-launcher with the default shortcut and type some text.

(3) Expected behavior:
I expect it not to crash :).

(4) Distribution (run cat /etc/os-release):
Manjaro Linux

(5) Gnome Shell version:
GNOME Shell 45.4

(6) Pop Shell version (run apt policy pop-shell or provide the latest commit if building locally):
1.2.0+303+g5fa3a50-1

(7) Where was Pop Shell installed from:
gnome-shell-extension-pop-shell package AUR

(8) Monitor Setup
2 x 1080p, both horizontal

(9) Other Installed/Enabled Extensions:
Issue detected with pop-shell being the only extension enabled.

(10) Other Notes:
I suspect is a recent commit to pop-shell. Yesterday it worked just fine. Today, after an update, this happens.

@nielsonrolim
Copy link

I got the same error running Ubuntu 23.10

@jacobgkau jacobgkau added the GNOME 45 Issues using the extension on GNOME 45. label Apr 3, 2024
@nielsonrolim
Copy link

nielsonrolim commented Apr 8, 2024

I reseted to the commit 9a30c5bd49c373896410852d6477596ac4c43bd3 so I could use in Gnome 45:

$ git reset --hard 9a30c5bd49c373896410852d6477596ac4c43bd3
$ make local-install

Then log off and login again.

@jerlam06
Copy link

jerlam06 commented May 3, 2024

I am having the same issue using pop-shell and pop-launcher on nixos.

@tyrion
Copy link

tyrion commented May 16, 2024

I have the same issue on nixos, and as suggested by @nielsonrolim pinning to that specific commit seems to fix the problem.

gnomeExtensions.pop-shell.overrideAttrs (old: {
  version = "unstable-2024-02-12";

  src = fetchFromGitHub {
    owner = "pop-os";
    repo = "shell";
    rev = "9a30c5bd49c373896410852d6477596ac4c43bd3";
    hash = "sha256-6JeD/2DtqGwUi946lssaBDYjUu4G5Gm3YWzW46nDGb4=";
  };
})

@jacobgkau
Copy link
Member

The commit after that is labeled "refactor: GNOME 46 port". It wasn't regression tested on GNOME 45 since that's beyond what Pop!_OS has shipped, anyway: #1704

I think the most feasible thing to do would probably be creating another branch. master_mantic is for 23.10, which included GNOME 45. The GNOME 46 version should be master_noble, since 24.04 includes GNOME 46.

@mmstick I just created master_noble, which is currently a copy of master_mantic. Can you make master_noble the default branch, and force-push master_mantic back to commit 9a30c5b for GNOME 45 users to use?

@jacobgkau
Copy link
Member

jacobgkau commented May 17, 2024

After we get the branches sorted out, we probably also need to update the README's explanation of which branch to use for which GNOME version.

GNOME 3.36 - 44: master_jammy
GNOME 45: master_mantic
GNOME 46+: master_noble

We still have master_focal around, too, and it references GNOME 3.36, even though the README currently lists 3.36-44 as being master_jammy. Not sure if master_jammy's supposed to start at a higher GNOME version (looks like 22.04 shipped with GNOME 42).

@mmstick
Copy link
Member

mmstick commented May 17, 2024

Done

@jacobgkau
Copy link
Member

Er, it looks like master_mantic is back on b5accce for GNOME 44 now. We want it on 9a30c5b for GNOME 45.

@jacobgkau
Copy link
Member

@mmstick Looks like I can't fix master_mantic myself since it's still a protected branch.

@petertheprocess
Copy link

I have the same issue, using GNOME 3.36 with master_jammy.

@mmstick
Copy link
Member

mmstick commented May 17, 2024

Done

@petertheprocess
Copy link

I have the same issue, using GNOME 3.36 with master_jammy.

I am using ubuntu 20.04 + GNOME Shell 3.36.4
master_jammy doesn't work for me, then I swithed to this commit and it works 0680690.

@jacobgkau
Copy link
Member

Ok, that commit's near where master_focal stops at, so that sounds like 20.04 users should indeed be using master_focal since 20.04 is Focal.

@petertheprocess
Copy link

Ok, that commit's near where master_focal stops at, so that sounds like 20.04 users should indeed be using master_focal since 20.04 is Focal.

Yeah, that make sense, maybe we should modify the readme. Now the hint is a litte bit misleading, at least for me, I was guided to use master_jammy because my GNOME Shell version is 3.36.4 but it doesn't work for 20.04.

The master_mantic git branch corresponds to Ubuntu 23.10 and supports GNOME 45+. For GNOME 3.36 through 44 support, use the master_jammy branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GNOME 45 Issues using the extension on GNOME 45.
Projects
None yet
Development

No branches or pull requests

7 participants