Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDM: Define the deme "size". Haploid, or diploid? #72

Open
grahamgower opened this issue Jun 8, 2021 · 12 comments
Open

MDM: Define the deme "size". Haploid, or diploid? #72

grahamgower opened this issue Jun 8, 2021 · 12 comments
Labels
Milestone

Comments

@grahamgower
Copy link
Member

I fear we might have overlooked this fundamentally important decision.

@jeromekelleher
Copy link
Member

I think it should number of individuals - the ploidy of these individuals is extrinsic to the demographic model specification.

Very good and important question, though!

@jeromekelleher jeromekelleher added this to the 1.0 milestone Jun 8, 2021
@apragsdale
Copy link
Member

Agreed - this should be the number of individuals. Will be important to clarify in the docs and paper.

@apragsdale
Copy link
Member

Also brings up a question - should we have ploidy as a top-level field in the specification? The default I assume would be 2, but users might wish to specify models for haploid, tetraploid, whatever-ploid species.

@jeromekelleher
Copy link
Member

Is it necessary for specifying the Demography, or is an extrinsic simulation parameter? (We have to draw the line somewhere)

@apragsdale
Copy link
Member

Yeah you're right, we don't want it to balloon too much. So then are we agnostic about matters of ploidy and those sorts of genome biology, or do we specifically have diploid models in mind (e.g. when talking about selfing rates)

@jeromekelleher
Copy link
Member

We're agnostic as far as I'm concerned, but I'm not into the details of selfing etc.

@grahamgower
Copy link
Member Author

grahamgower commented Jul 29, 2021

I'm inclined to think we might need a ploidy field too. Not having a ploidy field means a simulator can't simulate yaml files in a general way. The simulator will probably need to do different things for different ploidies, and there's no way to know what ploidy to use (without user intervention). Presumably folks will have a ploidy assumption for certain organisms (e.g. in stdpopsim), so the ploidy information will be stored somewhere (even if it's just assumed from the filename because it contains the organism name).

@jeromekelleher
Copy link
Member

I don't follow the logic - how is ploidy different to recombination rate, or genome length, or selection coefficients,...? Demes is never meant to be a complete description of a simulation, just of the demography. (Which again makes me wonder why we're putting cloning and selfing in...)

@grahamgower
Copy link
Member Author

To me, ploidy seems different to recombination rate and genome length, because a user can modify those for a given simulation and the demography still makes sense. But the demography only applies to one specific ploidy.

@apragsdale
Copy link
Member

I agree with Graham. They seem different to me, as selfing probability and ploidy are parameters about individuals (how many genome copies they carry and how they mate on the individual level) vs parameters about the genome copies themselves, which as pointed out can vary quite a bit between simulations without changing the meaning of the demography (and life history?) model. Is that a useful way to think about it?

@grahamgower
Copy link
Member Author

I think this ship has sailed, and we're not adding a ploidy field. But we do still need some statement that the deme sizes correspond to individuals (with whatever ploidy), rather than the number haploid chromosomes.

@grahamgower grahamgower changed the title Define the deme "size". Haploid, or diploid? MDM: Define the deme "size". Haploid, or diploid? Feb 8, 2022
@grahamgower grahamgower added the MDM label Feb 8, 2022
@jeromekelleher
Copy link
Member

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants