Skip to content

Commit db3880d

Browse files
committed
Upgrade github.com/coreos/butane from v0.13.1 to v0.14.0
* Drop TranslateBytesOptions.Strict field per changelog
1 parent 0f1a38b commit db3880d

File tree

3 files changed

+27
-19
lines changed

3 files changed

+27
-19
lines changed

ct/datasource_ct_config.go

Lines changed: 24 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -108,14 +108,16 @@ func renderConfig(d *schema.ResourceData) (string, error) {
108108

109109
// Translate Fedora CoreOS config to Ignition v3.X.Y
110110
func fccToIgnition(data []byte, pretty, strict bool, snippets []string) ([]byte, error) {
111-
ignBytes, _, err := butane.TranslateBytes(data, common.TranslateBytesOptions{
111+
ignBytes, report, err := butane.TranslateBytes(data, common.TranslateBytesOptions{
112112
Pretty: pretty,
113-
Strict: strict,
114113
})
115114
// ErrNoVariant indicates data is a CLC, not an FCC
116115
if err != nil {
117116
return nil, err
118117
}
118+
if strict && len(report.Entries) > 0 {
119+
return nil, fmt.Errorf("strict parsing error: %v", report.String())
120+
}
119121

120122
if len(snippets) == 0 {
121123
return ignBytes, nil
@@ -178,9 +180,8 @@ func mergeFCCSnippets(ignBytes []byte, pretty, strict bool, snippets []string) (
178180
// merge FCC v1.4.0 snippets
179181
func mergeFCC14(ign ignition33Types.Config, snippets []string, pretty, strict bool) (ignition33Types.Config, error) {
180182
for _, snippet := range snippets {
181-
ignextBytes, _, err := butane.TranslateBytes([]byte(snippet), common.TranslateBytesOptions{
183+
ignextBytes, report, err := butane.TranslateBytes([]byte(snippet), common.TranslateBytesOptions{
182184
Pretty: pretty,
183-
Strict: strict,
184185
})
185186
if err != nil {
186187
// For FCC, require snippets be FCCs (don't fall-through to CLC)
@@ -189,6 +190,10 @@ func mergeFCC14(ign ignition33Types.Config, snippets []string, pretty, strict bo
189190
}
190191
return ign, fmt.Errorf("snippet v1.4.0 translate error: %v", err)
191192
}
193+
if strict && len(report.Entries) > 0 {
194+
return ign, fmt.Errorf("strict parsing error: %v", report.String())
195+
}
196+
192197
ignext, _, err := ignition33.Parse(ignextBytes)
193198
if err != nil {
194199
return ign, fmt.Errorf("snippet parse error: %v, expect v1.4.0", err)
@@ -201,9 +206,8 @@ func mergeFCC14(ign ignition33Types.Config, snippets []string, pretty, strict bo
201206
// merge FCC v1.2.0 snippets
202207
func mergeFCC12(ign ignition32Types.Config, snippets []string, pretty, strict bool) (ignition32Types.Config, error) {
203208
for _, snippet := range snippets {
204-
ignextBytes, _, err := butane.TranslateBytes([]byte(snippet), common.TranslateBytesOptions{
209+
ignextBytes, report, err := butane.TranslateBytes([]byte(snippet), common.TranslateBytesOptions{
205210
Pretty: pretty,
206-
Strict: strict,
207211
})
208212
if err != nil {
209213
// For FCC, require snippets be FCCs (don't fall-through to CLC)
@@ -212,6 +216,10 @@ func mergeFCC12(ign ignition32Types.Config, snippets []string, pretty, strict bo
212216
}
213217
return ign, fmt.Errorf("snippet v1.2.0 translate error: %v", err)
214218
}
219+
if strict && len(report.Entries) > 0 {
220+
return ign, fmt.Errorf("strict parsing error: %v", report.String())
221+
}
222+
215223
ignext, _, err := ignition32.Parse(ignextBytes)
216224
if err != nil {
217225
return ign, fmt.Errorf("snippet parse error: %v, expect v1.2.0", err)
@@ -224,9 +232,8 @@ func mergeFCC12(ign ignition32Types.Config, snippets []string, pretty, strict bo
224232
// merge FCC v1.1.0 snippets
225233
func mergeFCC11(ign ignition31Types.Config, snippets []string, pretty, strict bool) (ignition31Types.Config, error) {
226234
for _, snippet := range snippets {
227-
ignextBytes, _, err := butane.TranslateBytes([]byte(snippet), common.TranslateBytesOptions{
235+
ignextBytes, report, err := butane.TranslateBytes([]byte(snippet), common.TranslateBytesOptions{
228236
Pretty: pretty,
229-
Strict: strict,
230237
})
231238
if err != nil {
232239
// For FCC, require snippets be FCCs (don't fall-through to CLC)
@@ -235,6 +242,10 @@ func mergeFCC11(ign ignition31Types.Config, snippets []string, pretty, strict bo
235242
}
236243
return ign, fmt.Errorf("snippet v1.1.0 translate error: %v", err)
237244
}
245+
if strict && len(report.Entries) > 0 {
246+
return ign, fmt.Errorf("strict parsing error: %v", report.String())
247+
}
248+
238249
ignext, _, err := ignition31.Parse(ignextBytes)
239250
if err != nil {
240251
return ign, fmt.Errorf("snippet parse error: %v, expect v1.1.0", err)
@@ -247,9 +258,8 @@ func mergeFCC11(ign ignition31Types.Config, snippets []string, pretty, strict bo
247258
// merge FCC v1.0.0 snippets
248259
func mergeFCCV10(ign ignition30Types.Config, snippets []string, pretty, strict bool) (ignition30Types.Config, error) {
249260
for _, snippet := range snippets {
250-
ignextBytes, _, err := butane.TranslateBytes([]byte(snippet), common.TranslateBytesOptions{
261+
ignextBytes, report, err := butane.TranslateBytes([]byte(snippet), common.TranslateBytesOptions{
251262
Pretty: pretty,
252-
Strict: strict,
253263
})
254264
if err != nil {
255265
// For FCC, require snippets be FCCs (don't fall-through to CLC)
@@ -258,6 +268,10 @@ func mergeFCCV10(ign ignition30Types.Config, snippets []string, pretty, strict b
258268
}
259269
return ign, fmt.Errorf("snippet v1.0.0 translate error: %v", err)
260270
}
271+
if strict && len(report.Entries) > 0 {
272+
return ign, fmt.Errorf("strict parsing error: %v", report.String())
273+
}
274+
261275
ignext, _, err := ignition30.Parse(ignextBytes)
262276
if err != nil {
263277
return ign, fmt.Errorf("snippet parse error: %v, expect v1.0.0", err)

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ require (
44
github.com/ajeddeloh/go-json v0.0.0-20170920214419-6a2fe990e083 // indirect
55
github.com/ajeddeloh/yaml v0.0.0-20170912190910-6b94386aeefd // indirect
66
github.com/alecthomas/units v0.0.0-20190924025748-f65c72e2690d // indirect
7-
github.com/coreos/butane v0.13.1
7+
github.com/coreos/butane v0.14.0
88
github.com/coreos/container-linux-config-transpiler v0.9.1-0.20200402130652-e4d5be564a0b
99
github.com/coreos/ignition v0.35.0
1010
github.com/coreos/ignition/v2 v2.13.0

go.sum

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -92,11 +92,10 @@ github.com/clarketm/json v1.14.1 h1:43bkbTTKKdDx7crs3WHzkrnH6S1EvAF1VZrdFGMmmz4=
9292
github.com/clarketm/json v1.14.1/go.mod h1:ynr2LRfb0fQU34l07csRNBTcivjySLLiY1YzQqKVfdo=
9393
github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=
9494
github.com/cncf/udpa/go v0.0.0-20191209042840-269d4d468f6f/go.mod h1:M8M6+tZqaGXZJjfX53e64911xZQV5JYwmTeXPW+k8Sc=
95-
github.com/coreos/butane v0.13.1 h1:VN7HcxBaqJAMTqJQn/RFAYzfjsv8LOOBjDYbhSCJzsY=
96-
github.com/coreos/butane v0.13.1/go.mod h1:m8mELrooVMftGW5uqHOfiwcBXvLG3XBch934zV2PhWY=
95+
github.com/coreos/butane v0.14.0 h1:1xLt5y6RR8NTmeDf6yMzqP7Jqre8PvJ/1BTXQTxEMhk=
96+
github.com/coreos/butane v0.14.0/go.mod h1:Q5DcBsHDckEZ7IgQSb1MvvkNc50dpoT1lOHdGWwCRjY=
9797
github.com/coreos/container-linux-config-transpiler v0.9.1-0.20200402130652-e4d5be564a0b h1:ncpb1vSLw4mC2l+3GNEGw2t0V0Gb+mHe0qIYZicwbT0=
9898
github.com/coreos/container-linux-config-transpiler v0.9.1-0.20200402130652-e4d5be564a0b/go.mod h1:SlcxXZQ2c42knj8pezMiQsM1f+ADxFMjGetuMKR/YSQ=
99-
github.com/coreos/go-json v0.0.0-20170920214419-6a2fe990e083/go.mod h1:FmxyHfvrCFfCsXRylD4QQRlQmvzl+DG6iTHyEEykPfU=
10099
github.com/coreos/go-json v0.0.0-20211020211907-c63f628265de h1:qZvNu52Tv7Jfbgxdw3ONHf0BK9UpuSxi9FA9Y+qU5VU=
101100
github.com/coreos/go-json v0.0.0-20211020211907-c63f628265de/go.mod h1:lryFBkhadOfv8Jue2Vr/f/Yviw8h1DQPQojbXqEChY0=
102101
github.com/coreos/go-semver v0.3.0 h1:wkHLiw0WNATZnSG7epLsujiMCgPAc9xhjJ4tgnAxmfM=
@@ -107,10 +106,8 @@ github.com/coreos/go-systemd/v22 v22.0.0 h1:XJIw/+VlJ+87J+doOxznsAWIdmWuViOVhkQa
107106
github.com/coreos/go-systemd/v22 v22.0.0/go.mod h1:xO0FLkIi5MaZafQlIrOotqXZ90ih+1atmu1JpKERPPk=
108107
github.com/coreos/ignition v0.35.0 h1:UFodoYq1mOPrbEjtxIsZbThcDyQwAI1owczRDqWmKkQ=
109108
github.com/coreos/ignition v0.35.0/go.mod h1:WJQapxzEn9DE0ryxsGvm8QnBajm/XsS/PkrDqSpz+bA=
110-
github.com/coreos/ignition/v2 v2.11.0/go.mod h1:uFhfdmeUfzT/8MqBvazzrLdzR3DvMCWR78GUYFRwPrs=
111109
github.com/coreos/ignition/v2 v2.13.0 h1:1ouW+d0nOuPUbLjxxOCnC+dWQxynr8Mt5exqJoCD7b4=
112110
github.com/coreos/ignition/v2 v2.13.0/go.mod h1:HO1HWYWcvAIbHu6xewoKxPGBTyZ32FLwGIuipw5d63o=
113-
github.com/coreos/vcontext v0.0.0-20210407161507-4ee6c745c8bd/go.mod h1:z4pMVvaUrxs98RROlIYdAQCKhEicjnTirOaVyDRH5h8=
114111
github.com/coreos/vcontext v0.0.0-20211021162308-f1dbbca7bef4 h1:pfSsrvbjUFGINaPGy0mm2QKQKTdq7IcbUa+nQwsz2UM=
115112
github.com/coreos/vcontext v0.0.0-20211021162308-f1dbbca7bef4/go.mod h1:HckqHnP/HI41vS0bfVjJ20u6jD0biI5+68QwZm5Xb9U=
116113
github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
@@ -382,7 +379,6 @@ github.com/stretchr/testify v1.7.0 h1:nwc3DEeHmmLAfoZucVR881uASk0Mfjw8xYJ99tb5Cc
382379
github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
383380
github.com/ulikunitz/xz v0.5.8 h1:ERv8V6GKqVi23rgu5cj9pVfVzJbOqAY2Ntl88O6c2nQ=
384381
github.com/ulikunitz/xz v0.5.8/go.mod h1:nbz6k7qbPmH4IRqmfOplQw/tblSgqTqBwxkY0oWt/14=
385-
github.com/vincent-petithory/dataurl v0.0.0-20160330182126-9a301d65acbb/go.mod h1:FHafX5vmDzyP+1CQATJn7WFKc9CvnvxyvZy6I1MrG/U=
386382
github.com/vincent-petithory/dataurl v1.0.0 h1:cXw+kPto8NLuJtlMsI152irrVw9fRDX8AbShPRpg2CI=
387383
github.com/vincent-petithory/dataurl v1.0.0/go.mod h1:FHafX5vmDzyP+1CQATJn7WFKc9CvnvxyvZy6I1MrG/U=
388384
github.com/vmihailenco/msgpack v3.3.3+incompatible/go.mod h1:fy3FlTQTDXWkZ7Bh6AcGMlsjHatGryHQYUTf1ShIgkk=
@@ -718,8 +714,6 @@ gopkg.in/yaml.v2 v2.2.4/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
718714
gopkg.in/yaml.v2 v2.2.8/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
719715
gopkg.in/yaml.v2 v2.3.0 h1:clyUAQHOM3G0M3f5vQj7LuJrETvjVot3Z5el9nffUtU=
720716
gopkg.in/yaml.v2 v2.3.0/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
721-
gopkg.in/yaml.v3 v3.0.0-20190502103701-55513cacd4ae/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
722-
gopkg.in/yaml.v3 v3.0.0-20191010095647-fc94e3f71652/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
723717
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
724718
gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b h1:h8qDotaEPuJATrMmW04NCwg7v22aHH28wwpauUhK9Oo=
725719
gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=

0 commit comments

Comments
 (0)