Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/markdown/comment.go: consider exposing whole package or ToMarkdown #71

Open
mbana opened this issue Mar 9, 2019 · 2 comments

Comments

@mbana
Copy link

mbana commented Mar 9, 2019

Would be useful to be able to import and use ToMarkdown as defined in here https://github.com/posener/goreadme/blob/master/internal/markdown/comment.go#L284.

Might be helpful to just the internal package altogether. Not sure...

@posener
Copy link
Owner

posener commented Mar 23, 2019

Hi, Sorry for the long delay.

Totally agree.
Actually, if you look at the first line in this file, I copied and modified this code from the go source code file: https://github.com/golang/go/blob/master/src/go/doc/comment.go

The original code has ToText and ToHTML converters. I needed a markdown converter.

WDYT?

@mbana
Copy link
Author

mbana commented Mar 26, 2019

Hi, plan to use it to resolve this issue saibing/bingo#69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants