Provide predictable startup ordering #5959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: sharon <[email protected]> Signed-off-by: Jonathan <[email protected]>
|
E2E Tests 🚀 ? |
timtmok
reviewed
Jan 13, 2025
| * | ||
| * Returns a promise that resolves to the session ID of the new session. | ||
| */ | ||
| startNewRuntimeSession(runtimeId: string, | ||
| sessionName: string, | ||
| sessionMode: LanguageRuntimeSessionMode, | ||
| notebookUri: URI | undefined, | ||
| source: string): Promise<string>; | ||
| source: string, |
There was a problem hiding this comment.
Looks like a duplicate from a merge?
There was a problem hiding this comment.
Thanks for spotting that, the history of this branch is a little wonky because it was split off from the persistence work due to overlaps! Addressed now.
|
This is a feature that I didn't realize that I wanted! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change eliminates the disorienting startup experience that can occur when multiple affiliated runtimes exist (or multiple sessions are running).
Prior to the change, every runtime start or reconnect resulted in the new session taking over the Console and Variables panes and becoming the active session. Practically speaking this meant that startup often showed some flickering as different sessions booted and Positron switched between them on its own, and the session you wound up with when startup was finished might not be the one you wanted or expected.
After the change, sessions and affiliated runtimes are ordered, and only one console session gets to become active. The other sessions are still started -- they just start in the background. The result is (hopefully) a calmer startup experience.
Right now, there is no explicit ordering -- we just go by whichever one was last used. So if you were using Python when you exited, that's what you should see when you open Positron again; same deal with R.
The implementation works as follows:
activateflag everywhere we deal with session start events to keep track of whether the session should be focused/activated after it startsactivateif they are the most recently usedAddresses #1044 and part of #1143.
Release Notes
New Features
Bug Fixes
QA Notes