-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure cli file hyperlinks for R package dev tasks #5850
Conversation
E2E Tests 🚀 ? |
e0c3be7
to
6ea7a38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah actually, I've got one more request. Can you add the tag for R package tests to this PR, to run those specific tests? More info at:
https://github.com/posit-dev/positron/blob/main/test/e2e/README.md#pull-requests-and-test-tags
@juliasilge I think I've successfully added the correct tag. And yet no new test run has happened. Is there some additional step? Do I just need to ... push an empty commit? |
I believe you can either push an empty commit or click to rerun the jobs. |
I just did rerun all jobs. |
The test run passed ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
Addresses #5409
Needed to wait for r-lib/cli#744, which is now merged
@:r-pkg-development
QA Notes
Pre-requisite: You need to install a very recent version of the cli package. At the time I write this, this means a dev version of cli, although I think we'll get a release out fairly soon. In the meantime, a good way to install is:
Make sure the cli version is >= 3.6.3.9002:
There won't be any obvious error in the presence of an older cli version, but the new functionality just won't activate.
Then you need to run tests on a package with one or more failing tests, in order to be able to click on the filepath when test failure is reported. This should take you directly to the relevant test location.
I have made a toy package that could be obtained via
usethis::create_from_github("jennybc/clilinks")
. It has a couple of snapshot tests that will always fail 😄 because they attempt to snapshot a random number. But really any package with a failing test will do.pak::pak("r-lib/cli")
usethis::create_from_github("jennybc/clilinks")
Note that this PR removes the feature flag introduced in #5231, since now all hyperlinks work (if the cli version is recent enough). If you configured
positron://settings/positron.r.taskHyperlinks
in the interim, that setting can be removed and, indeed, no longer exists.