remove extra code around check_output

Author: bcwu

rsconnect/actions.py

@@ -1535,7 +1535,6 @@ def create_notebook_deployment_bundle(
                 hide_all_input,
                 hide_tagged_input,
                 image=image,
-                check_output=None,
             )
         except subprocess.CalledProcessError as exc:
             # Jupyter rendering failures are often due to

rsconnect/bundle.py

@@ -369,12 +369,9 @@ def make_notebook_html_bundle(
     hide_all_input: bool,
     hide_tagged_input: bool,
     image: str = None,
-    check_output: typing.Callable = subprocess.check_output,  # used to default to subprocess.check_output
+    check_output: typing.Callable = subprocess.check_output,
 ) -> typing.IO[bytes]:
     # noinspection SpellCheckingInspection
-    if check_output is None:
-        check_output = subprocess.check_output
-
     cmd = [
         python,
         "-m",

tests/test_bundle.py

@@ -225,7 +225,11 @@ def do_test_html_bundle(self, directory):
         nb_path = join(directory, "dummy.ipynb")
 
         bundle = make_notebook_html_bundle(
-            nb_path, sys.executable, hide_all_input=False, hide_tagged_input=False, image=None, check_output=None
+            nb_path,
+            sys.executable,
+            hide_all_input=False,
+            hide_tagged_input=False,
+            image=None,
         )
 
         tar = tarfile.open(mode="r:gz", fileobj=bundle)