Conditionally applying aspect

[lukedays]

Hi all,

First of all, thanks a lot for the library!
Is it possible to conditionally apply the OverrideMethodAspect based on parameters?

Example:

if (!meta.Target.Parameters["cache"].Value)
{
    return meta.Proceed(); // Don't cache
}
else
{
    // Cache logic...
}

This gives an error: Cannot implicitly convert type 'object' to 'bool'.
I tried casting to bool with no success.

Thanks in advance!

[gfraiteur]

This code (open in online sandbox) works for me:

    public override dynamic? OverrideMethod()
    {
        // Builds the caching string.
        var cacheKey = GetCachingKeyFormattingString().ToValue();

        var cacheParameter = meta.Target.Parameters.SingleOrDefault( p => p.Name == "skipCache" );

        if ( cacheParameter != null )
        {
            if ( (bool) cacheParameter.Value )
            {
                return meta.Proceed();
            }
        }

        // Cache lookup.
        if ( SampleCache.Cache.TryGetValue( cacheKey, out object value ) )
        {
            // Cache hit.
            return value;
        }
        else
        {
            // Cache miss. Go and invoke the method.
            var result = meta.Proceed();

            // Add to cache.
            SampleCache.Cache.TryAdd( cacheKey, result );
      }
   }

[lukedays]

Hello, thanks for looking into this!
Unfortunately it didn't work. The function I'm applying the aspect has a generic parameter, and the example stops working as well if I add one.
I managed to reproduce the error on my machine (repo) and on the sandbox.

Program.cs(21,28): error CS0117: 'Program' does not contain a definition for 'Add_Source'

Thanks in advance!

[gfraiteur]

I have created a new issue for this. Please follow the new issue to get pinged.