Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sugestion to scale some Label data when decimating or interpreting #169

Open
ashley-b opened this issue Mar 30, 2019 · 2 comments
Open

Sugestion to scale some Label data when decimating or interpreting #169

ashley-b opened this issue Mar 30, 2019 · 2 comments

Comments

@ashley-b
Copy link
Contributor

I was thinking it would be useful if rate transforming blocks i.e. decimating/interpolating filter could also scale some label data like "rxRate" and perhaps other user labels.
This could be done though a registry of labels to scale or a flag in the label maybe?

https://github.com/pothosware/PothosComms/blob/61d10f4d2c0523906207e91ec02ac86f6658653a/filter/FIRFilter.cpp#L307-L314

@guruofquality
Copy link
Contributor

I havent thought deeply about making some tag registry, but I did make this specific FIR block adjust the rate when passed in with the rxRate id specifically :-)

@ashley-b
Copy link
Contributor Author

Great, thanks for that. I will checkout it out.

I was thinking after I posted this sugestion that perhaps "rxRate" Label value should be transform in Label::toAdjusted method, so all new rate transforming blocks get this for free. But I have noticed its also used to shift labels due to data type transformation not just rate transforms.

As for a way to signal if a Label value should be adjusted, maybe a flag in the Label class would be the easiest way. So that a block adding labels (e.g SDR source) can set it, if it needs the value to be adjusted downstream.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants