Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons sometimes appear black in Kirigami and Mauikit applications. #23

Open
poudink opened this issue Mar 13, 2023 · 6 comments
Open

Icons sometimes appear black in Kirigami and Mauikit applications. #23

poudink opened this issue Mar 13, 2023 · 6 comments
Labels

Comments

@poudink
Copy link
Owner

poudink commented Mar 13, 2023

This is a Kirigami bug. https://bugs.kde.org/show_bug.cgi?id=451538

@poudink
Copy link
Owner Author

poudink commented Apr 17, 2023

This is especially bad in Maui applications. Almost every icon is made monochromatic. Some applications become very difficult to use, since these icons weren't exactly intended to be seen as simple silhouettes, making it difficult to distinguish buttons from one another, as many of them lack labels.

@poudink
Copy link
Owner Author

poudink commented May 21, 2023

https://invent.kde.org/frameworks/kirigami/-/commit/66c6a75d44353c15101d872396be66b92d1c33e6

Should be fixed in Frameworks 5.107. 5.106 was just released, so I imagine there's still a long time to go until the release. Will be closing once it happens.

@poudink
Copy link
Owner Author

poudink commented May 21, 2023

Looking at the commit, this is only going to solve cases where we're not using a symbolic-suffixed icon but the app wants a symbolic-suffixed icon, so the app treats our non-symbolic icon as a symbolic icon.

This won't fix cases where we're using a symbolic-suffixed icon that isn't actually symbolic, which we need to do because GTK apps won't fallback to the non-symbolic version and will instead fall back to Breeze.

@poudink
Copy link
Owner Author

poudink commented May 23, 2023

Wait, now I'm confused. The issue I linked in this issue was closed by the PR mentioned above, even though it seems to be pertaining to the cases my last comment just says wouldn't be fixed. Also, I was wrong. Frameworks apparently releases monthly, so 5.107 will happen quite soon in June. I thought it was on an triannual schedule similar to KDE Gear and Plasma.

@poudink poudink changed the title Icons sometimes appear black in Kirigami applications. Icons sometimes appear black in Kirigami and Maui applications. May 29, 2023
@poudink poudink changed the title Icons sometimes appear black in Kirigami and Maui applications. Icons sometimes appear black in Kirigami and Mauikit applications. May 29, 2023
@poudink
Copy link
Owner Author

poudink commented May 29, 2023

So, I thought this was a problem universal to Maui applications, but it turns out it isn't. I just tried out the new Bonsai, Fiery and Strike applications from the recent Maui 3.0 release and the icons in them are being displayed correctly. I took a second look at some of the older Maui applications and it turns the problem is actually far from universal, though it is definitely more common than it is in regular Kirigami applications.

@poudink
Copy link
Owner Author

poudink commented Jun 13, 2023

Upgraded to 5.107 and as I thought this hasn't been completely fixed. It seems sidebars are the problem. Like the ones in Alligator, AudioTube or Index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant