Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make activity full screen instead of dialog #8

Open
PhilippC opened this issue Dec 3, 2018 · 0 comments
Open

Make activity full screen instead of dialog #8

PhilippC opened this issue Dec 3, 2018 · 0 comments

Comments

@PhilippC
Copy link

PhilippC commented Dec 3, 2018

Android's onActivityResult doesn't seem to be called after activity recreation in combination with dialog themes:
https://stackoverflow.com/questions/53456335/onactivityresult-not-called-when-starting-a-dialog-activity-and-recreating-activ
I might add many configChanges flags to my activities, but that doesn't solve the problem (only make it occur less frequently). However, if ykDroid wouldn't use a dialog theme for its activity, no problems in using it should occur.
PhilippC pushed a commit to PhilippC/keepass2android that referenced this issue Dec 3, 2018
added ConfigChanges flags to all activities which could potentially s…
7f21fa2 
…how the ykDroid dialog to reduce the chance of activity recreation (this is considered a workaround, waiting for the solution at pp3345/ykDroid#8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PhilippC