Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Microsoft Edge #352

Closed
linh-ngophuochoai opened this issue Apr 18, 2021 · 6 comments · Fixed by #408
Closed

Add support for Microsoft Edge #352

linh-ngophuochoai opened this issue Apr 18, 2021 · 6 comments · Fixed by #408
Assignees
Milestone

Comments

@linh-ngophuochoai
Copy link
Contributor

Hi Team,

I would like to request support for Microsoft Edge and Safari.

Those 2 two major browsers and the support will help with cross-browser testing.

Regards,

@UltimateDogg
Copy link
Collaborator

Safari is not on linux and edge is only a dev package thats beta and isnt built for alpine so i dont see how this could be added to this image

@linh-ngophuochoai
Copy link
Contributor Author

Hi,

Thank you for the information. I have found the effort to test locally those browsers is outweigh the benefit. It turns out that just need to use BrowserStack to overcome this issue

@jeabakker
Copy link
Contributor

@UltimateDogg
Would it be possible to have another look at MS Edge?
I can see there is a Linux installation available for the webdriver https://developer.microsoft.com/en-us/microsoft-edge/tools/webdriver/
And some more documentation https://docs.microsoft.com/en-us/microsoft-edge/webdriver-chromium/?tabs=c-sharp

@ppodgorsek
Copy link
Owner

This ticket was broken in two parts in order to better track those individual features. See issue #401 for the Safari support.

@ppodgorsek ppodgorsek changed the title Add support for Microsoft Edge and Safari Add support for Microsoft Edge Apr 13, 2022
@jeabakker
Copy link
Contributor

@ppodgorsek thanks for reopening this issue.

Any idea on the timeline for implementation? I really need it ;) if it takes a bit longer than I have to look into how to make this work for me.

I might have to look into creating a PR.....

jeabakker added a commit to ColdTrick/docker-robot-framework that referenced this issue May 11, 2022
jeabakker added a commit to ColdTrick/docker-robot-framework that referenced this issue May 12, 2022
@yuki-s0111
Copy link

Hi Team,
I have made it work on the latest version of edge using webdriver for this Issue,
Can I create a PR?
The previous one was rejected by the test.

ppodgorsek added a commit that referenced this issue Sep 6, 2023
* Merged the latest changes from the master branch

* Fixed issues with the CI tests, as the Browser library currently doesn't support Microsoft Edge by default
ppodgorsek added a commit that referenced this issue Sep 6, 2023
@ppodgorsek ppodgorsek added this to the 6.1.1 milestone Sep 6, 2023
@ppodgorsek ppodgorsek moved this to In Progress in Robot Framework in Docker Sep 6, 2023
ppodgorsek added a commit that referenced this issue Sep 6, 2023
* Fixed a syntax mistake
ppodgorsek added a commit that referenced this issue Sep 6, 2023
* Fixed a syntax mistake
ppodgorsek added a commit that referenced this issue Sep 6, 2023
* Replaced Docker by Podman in the CI pipeline
ppodgorsek added a commit that referenced this issue Sep 6, 2023
Issue #352 - Add support for Microsoft Edge
@github-project-automation github-project-automation bot moved this from In Progress to Done in Robot Framework in Docker Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants