Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adopt google workbox to init PWA setup #41

Closed
3 tasks done
Tracked by #37
xiaohanyu opened this issue Apr 24, 2024 · 3 comments
Closed
3 tasks done
Tracked by #37

feat: adopt google workbox to init PWA setup #41

xiaohanyu opened this issue Apr 24, 2024 · 3 comments
Assignees
Labels
feat New feature or request frontend Frontend related
Milestone

Comments

@xiaohanyu
Copy link
Member

xiaohanyu commented Apr 24, 2024

Description

workbox seems to be the defac to way to enable PWA for a web site. We want to integrate it and avoid re-invent wheels.

[Optional] Possible Solutions

  • adopt next-pwa, however this project seems not actively maintained any more, it has issue with next.js 14
  • adopt serwist, which is a revised fork of workbox and provides next.js support

Acceptance Criteria

  • setup workbox with PPResume workflow

Todo list

Tasks

@xiaohanyu xiaohanyu self-assigned this Apr 24, 2024
@xiaohanyu xiaohanyu added feat New feature or request frontend Frontend related labels Apr 24, 2024
@xiaohanyu xiaohanyu added this to the M-0.5 milestone Apr 24, 2024
@xiaohanyu
Copy link
Member Author

We decided to use serwist, reasons:

  • it is actively maintained
  • next-pwa's development has been stopped for 2 years
  • adopt raw workbox requires too much labor.

@xiaohanyu
Copy link
Member Author

There're some difference for cache behaviour when process.env.NODE_ENV is switching from development to production

  • the cache storage won't be populated when process.env.NODE_ENV is development, check code here

@xiaohanyu
Copy link
Member Author

Overall serwist is pretty good, though its docs is not very complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request frontend Frontend related
Projects
None yet
Development

No branches or pull requests

1 participant