Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: reduce latency when create/delete resumes #91

Open
xiaohanyu opened this issue Jul 19, 2024 · 0 comments
Open

perf: reduce latency when create/delete resumes #91

xiaohanyu opened this issue Jul 19, 2024 · 0 comments
Assignees
Labels
perf Performance related
Milestone

Comments

@xiaohanyu
Copy link
Member

xiaohanyu commented Jul 19, 2024

Description

Right now there's 2-4 seconds latency when users create or delete resumes, we can optimize this and give users instant feedbacks.

Demo:

create-delete-resume-latency.mp4

[Optional] Possible Solutions

Right now when user create or delete resumes, we send two requests:

  1. POST /resumes or DELETE /resumes/:slug
  2. GET /resumes for a refetch of all resumes and refresh the whole resume list

We can instead, first update the zustand resumes store when create/delete resumes (this would be instant), and then after POST /resumes or DELETE /resumes/:slug respond, we check the status code and act accordingly.

Acceptance Criteria

  • the UI latency for create/delete resumes should be removed

Todo list

NA

@xiaohanyu xiaohanyu self-assigned this Jul 19, 2024
@xiaohanyu xiaohanyu added the perf Performance related label Jul 19, 2024
@xiaohanyu xiaohanyu added this to the M-X.0 milestone Jul 19, 2024
@xiaohanyu xiaohanyu changed the title feat: reduce latency when create/delete resumes perf: reduce latency when create/delete resumes Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf Performance related
Projects
None yet
Development

No branches or pull requests

1 participant