Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect slider nodes deleted #31308

Closed
kelinimo opened this issue Dec 27, 2024 · 3 comments · Fixed by #31348
Closed

Incorrect slider nodes deleted #31308

kelinimo opened this issue Dec 27, 2024 · 3 comments · Fixed by #31348
Assignees

Comments

@kelinimo
Copy link

kelinimo commented Dec 27, 2024

Type

Game behaviour

Bug description

When one node is selected and then you try to delete some other node (not holding Control or anything) it deletes both nodes.

I'd expect the node selection to be "reset" on middle mouse click

Screenshots or videos

2024-12-27.16-57-53.mp4

Version

2024.1224.1-lazer

Logs

compressed-logs.zip

@peppy
Copy link
Member

peppy commented Dec 28, 2024

I can't reproduce this. Also the code says this would only be the case if you had the node that you're targeting to delete selected.

private void handleQuickDeletion(SelectionBlueprint<T> blueprint)
{
if (blueprint.HandleQuickDeletion())
return;
if (!blueprint.IsSelected)
DeleteItems(new[] { blueprint.Item });
else
DeleteSelected();
}

@kelinimo
Copy link
Author

What were the buttons you tried? Because for me the issue is very consistent. It doesn't happen when using Shift + Right Click. But on middle click it happens every time

@hrfarmer
Copy link
Contributor

Can repro as well
The click on the first node is a left click, and the click on the second node is middle click.
https://github.com/user-attachments/assets/56a7b86b-77c4-4305-aedb-b0a29fe6c263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants