-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should the special keyword balance be allowed in the species dictionary to indicate the remaining mole fraction? #58
Comments
My initial thought is no, that the user can do the subtraction and put in a number. This might be prone to typos, but it will be the easiest to handle on our end. Other thoughts? |
Yeah this seems like a "lazy" (or, more charitably, "convenience") option that doesn't provide much value—explicit is better than implicit :) Although requiring the amount to be specified might introduce one other possible avenue for typos, I think forcing this actually would lead to fewer overall errors, because our validation will check that everything adds up correctly. With a |
Good point! Although I was doing some work today and found a typo that I made where I did the rounding incorrectly, so YMMV 😄 |
Hah ok, well I can't guarantee saving you from all your typos :) |
From Mike Burke via email:
|
That's a pretty good point. Is there some way we can incorporate Kyle's comment about catching typos, and this uncertainty idea? Perhaps a new field |
PyKED/ChemKED version
v0.1.5
Title question suggested by Mike Burke's group at Columbia
The text was updated successfully, but these errors were encountered: