Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jet Stirred Reactor profiles. #11

Open
rwest opened this issue Feb 8, 2019 · 0 comments
Open

Jet Stirred Reactor profiles. #11

rwest opened this issue Feb 8, 2019 · 0 comments

Comments

@rwest
Copy link
Member

rwest commented Feb 8, 2019

We want to work towards evaluating models against JSR species profile data.
Quite a lot of PyTeCK currently assumes the only thing it ever tries to do is ignition delays, so we'd need to do some restructuring before we can start.

Thoughts?

  • Make a parent class and subclasses, with methods like evaluate_model etc?
  • Make modules for ignition and jsr each with classes like Simulation?
  • Make Simulation parent class, with JSRSimulation and IgnitionSimulation as subclasses (the latter being the current Simulation class)?

Guidance appreciated. Happy to chat if that's more efficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant