Getting "Warning: Invalid hook call." when using locally in App due to double React

[jnachtigall]

Describe the bug
I use the library locally so I can make a few changes. This way I hit this error: https://stackoverflow.com/questions/56021112/react-hooks-in-react-library-giving-invalid-hook-call-error/57422196

The package.json has

react-chrono/package.json

Lines 39 to 41 in 9c7bc09

	"peerDependencies": {
	"react": "^18.1.0",
	"react-dom": "^18.1.0"

and the rollup config has

react-chrono/rollup.config.mjs

Line 54 in 9c7bc09

PeerDepsExternalPlugin(),

The problem is that the package.json also has these dependencies too:

react-chrono/package.json

Lines 94 to 95 in 9c7bc09

	"react": "^18.2.0",
	"react-dom": "^18.2.0",

These last lines should be deleted and only peerDependencies used.

BTW:
There is also

react-chrono/package.json

Line 96 in 9c7bc09

"react-is": "^18.2.0",

But react-is does not seem to be used anywhere.

[prabhuignoto]

@jnachtigall Thanks for reporting the issue. can you share the repo details where this issue can be reproduced.

[jnachtigall]

No, the repo is private. But it is easy to reproduce:

1. Create a CRA next to your react-chrono folder
2. In this CRA install react-chrono from you local folder with:
   npm install ../react-chrono/
3. Use this react-chrono in your CRA project. Then you'll hit the above error.

[prabhuignoto]

@jnachtigall

These last lines should be deleted and only peerDependencies used.

devDependencies cannot be modified as react and react-dom are important dependencies for development.

Are you trying to contribute back to the project or you want to customize and use it back in your project. If its for the later reason, then its ideal to make changes on the main repo first.