Added contact details to CV #9
Conversation
|
Hi @kwennB Thanks for the PR. I'll review it by EOD today. |
Thank you @praneeth-rdy |
There was a problem hiding this comment.
Hi @kwennB
Did you observe the other alignment differences in the CV templates due to the addition of contact details?
Please check and fix these:
- The text got aligned to left in template-1 which is creating unnecessary space towards the right and not according to the actual IITKGP template.
- College logo position is hampered in template-2.
- Better to have the contact column at the right-extreme in template-3.
Could you please fix these?
Hi @praneeth-rdy |
|
Hello @praneeth-rdy I have pushed the fixes to this PR. |
|
Hello @praneeth-rdy Did you get a chance to review the edits on the PR? |
There was a problem hiding this comment.
Hi @kwennB
Sorry for the delay. I was quite occupied last week.
I've reviewed the changes and found the following issues.
- In template-1, the contact info isn't centred and the increase in contact URL length is pushing the header towards the left.
- In template-3, the color of the contact section is too overlapping with the background white. It's only visible when we hover over it.
- Editing the contact is not updating the href of the contact.
Could you fix these? Let me know If you feel it's too heavy. I can hop in and work on this issue.
|
I apologize for the late response, I'll give them a short first as soon as I can. |
|
Hi @kwennB, Are you still interested in continuing with this PR? Best Regards, |
fixes #6
Proposed Changes