image adding feature added in IIT kgp template #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you remove the animation on the text "Click on profile to change it"? It seems too flashy. The rest looks good to me. Thanks for the PR. Best Regards, |
3 tasks
|
I have given that animation for attracting attention to this instruction,
as we are not giving any edit btn/notice near the profile pic. so how a
user will know that by clicking it , he/she can change it, simply written
notice may be ignored by the user that's why I animated it, I thought this
way.
once you read this mail, give me final confirmation to remove the animation
from it, I will remove it. : )
…On Tue, Jun 27, 2023 at 3:12 PM Praneeth Reddy Kolanu < ***@***.***> wrote:
Hi @Gaurav05082002 <https://github.com/Gaurav05082002>
Can you remove the animation on the text "Click on profile to change it"?
It seems too flashy.
The rest looks good to me. Thanks for the PR.
Best Regards,
Praneeth
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATJQTC5UKEHEP35N3T466S3XNKTH7ANCNFSM6AAAAAAZT7CS5E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Gaurav Patidar*
*Tech Team Head | Spring Fest |*
*Indian Institute Of Technology, Kharagpur*
*+917689816680*
***@***.*** ***@***.***>*
https://www.linkedin.com/in/gaurav-patidar-809997207/
|
|
Got your point but the first written statement on the page is this instruction. I don't think one would ignore that. Also, the animation looks different from the simpler theme of the site. So, I'd still suggest to remove the animation for now. Also, change the placeholder image to a dummy one instead of a real image of a person. Best Regards, |
|
okay , done
regards
…On Tue, Jun 27, 2023 at 6:53 PM Praneeth Reddy Kolanu < ***@***.***> wrote:
Got your point but the first written statement on the page is this
instruction. I don't think one would ignore that. Also, the animation looks
different from the simpler theme of the site.
Also, change the placeholder image to a dummy one instead of a real image
of a person.
Sample:
https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcRVM9evfKqxhXvNhGi9F50DoiDJ14vGd3dnJg&usqp=CAU
Best Regards,
@praneeth-rdy <https://github.com/praneeth-rdy>
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATJQTC655K2YVEJYCSZMJTLXNLNFPANCNFSM6AAAAAAZT7CS5E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Gaurav Patidar*
*Tech Team Head | Spring Fest |*
*Indian Institute Of Technology, Kharagpur*
*+917689816680*
***@***.*** ***@***.***>*
https://www.linkedin.com/in/gaurav-patidar-809997207/
|
praneeth-rdy
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
to @praneeth-rdy
Regards
gaurav