Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yieldlab Bidder: Forward consent under param gdpr_consent #3720

Merged
merged 5 commits into from
Feb 10, 2025
Merged

Yieldlab Bidder: Forward consent under param gdpr_consent #3720

merged 5 commits into from
Feb 10, 2025

Conversation

AntoxaAntoxic
Copy link
Collaborator

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@AntoxaAntoxic AntoxaAntoxic linked an issue Jan 31, 2025 that may be closed by this pull request
Port PR from PBS-Go: Yieldlab: Forward consent under param gdpr_consent #3703
Closed
@AntoxaAntoxic AntoxaAntoxic self-assigned this Jan 31, 2025
CTMBNara
CTMBNara requested changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@CTMBNara CTMBNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see many differences in the adapter logic in relation to the GO. Please correct them all:

  • different makeFormats
  • there is not schain support
  • there also may be other differences

CTMBNara
CTMBNara requested changes Feb 6, 2025
View reviewed changes
src/main/java/org/prebid/server/bidder/yieldlab/YieldlabBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/yieldlab/YieldlabBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/yieldlab/YieldlabBidder.java Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/yieldlab/YieldlabBidder.java Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/yieldlab/YieldlabBidder.java Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/yieldlab/YieldlabBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/yieldlab/YieldlabBidder.java Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/yieldlab/YieldlabBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/yieldlab/YieldlabBidder.java Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/yieldlab/YieldlabBidder.java Show resolved Hide resolved
@CTMBNara
Copy link
Collaborator

CTMBNara commented Feb 6, 2025

To be continued....

@osulzhenko osulzhenko requested a review from CTMBNara February 7, 2025 07:35
CTMBNara
CTMBNara reviewed Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@CTMBNara CTMBNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, delete this debug logic and all things that related to it. It's not present in GO. I also checked the git history and it seems this was added to satisfy integration tests.

// for passing validation tests
        final String timestamp = isDebugEnabled(request) ? "200000" : String.valueOf(clock.instant().getEpochSecond());

CTMBNara
CTMBNara requested changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@CTMBNara CTMBNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still differences in logic of makeBids. It would also be nice if you refactored this part as well, there are a lot of things that could be simplified or optimized.

@osulzhenko osulzhenko requested a review from CTMBNara February 10, 2025 13:12
@CTMBNara CTMBNara merged commit aac0305 into master Feb 10, 2025
8 checks passed
@CTMBNara CTMBNara deleted the yieldlab-bidder-gdpr-consent branch February 10, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CTMBNara CTMBNara CTMBNara approved these changes

Assignees

@AntoxaAntoxic AntoxaAntoxic

Labels
do not port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: Yieldlab: Forward consent under param gdpr_consent
2 participants
@AntoxaAntoxic @CTMBNara