Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port PR from PBS-Go: New Adapter: Ogury #3700

Open
cross-repo-issue-creation bot opened this issue Jan 24, 2025 · 5 comments · May be fixed by #3788
Open

Port PR from PBS-Go: New Adapter: Ogury #3700

cross-repo-issue-creation bot opened this issue Jan 24, 2025 · 5 comments · May be fixed by #3788
Assignees
Labels

Comments

@cross-repo-issue-creation
Copy link

A PR was merged over on PBS-Go

@YuriyVelichkoPI
Copy link

Hi @bretg, @osulzhenko ! Please, assign this tasks to @zxPhoenix. if it is not in progress yet and timeline (2-3 weeks) is good for you. It will be contributed on behalf of Raptive.

@zxPhoenix
Copy link
Contributor

Hi @osulzhenko , I see unnecessary http redirect for Ogury endpoint because of http protocol instead of https. Is it makes some sense to have http here ogury.yaml?
It seems that Vertx.io doesn't support redirect for POST requests:HttpClient doesn't handle 308 redirect #3038, Vertx.io redirect documentation

@krdzo
Copy link

krdzo commented Feb 14, 2025

Hello @zxPhoenix,
I'm the dev that wrote the ogury adapter on PBS.
This is an oversight on my part, it should be https, so yeah you should change it.
I will shortly make a PR on PBS to fix this

@YuriyVelichkoPI
Copy link

Hi @krdzo ! Could you provide assetKey and adUnitId to test code processing real responses from ogury?

@krdzo
Copy link

krdzo commented Feb 20, 2025

Hello @YuriyVelichkoPI here is some test asset that you can try:
assetKey = 'OGY-C3FE4ADC0126'
adUnitId = '0251ec40-fc3b-0139-afe5-0242ac120004' NOTE this is a mobile asset so it works only on mobile view, it doesn't work on desktop.

You will probably also need to set site.page in the request to https://example.com/?ogy_test_mode=image for it to work.

@zxPhoenix zxPhoenix linked a pull request Feb 26, 2025 that will close this issue
21 tasks
@osulzhenko osulzhenko linked a pull request Feb 28, 2025 that will close this issue
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for Dev
Development

Successfully merging a pull request may close this issue.

3 participants