Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential ESM compatibility issue triggered with vercel/ncc #74

Open
ldng opened this issue Aug 2, 2024 · 1 comment
Open

Potential ESM compatibility issue triggered with vercel/ncc #74

ldng opened this issue Aug 2, 2024 · 1 comment

Comments

@ldng
Copy link

ldng commented Aug 2, 2024

Hi,

Apparently a 6 years old Webpack warning fix could be breaking vercel/ncc when trying to compile dependencies that relies on gyp-build when using ES modules :
vercel/ncc#899 (comment)

Not sure whether it is real or if it's just the tree hiding the forest but still, is the fix still relevant nowadays or could be removed/reworked ?
Is it just a Webpack warning or is there a real error behind ?

Regards

@ldng
Copy link
Author

ldng commented Aug 3, 2024

ldng@345f945
FYI, reverting to just plain require does fix my issue; I now can nearly properly use @vercel/ncc by also patching the result with
a little bit of help from sed ... (vercel/ncc#791 (comment))

Now, I don't doubt this was put in place for a reason but I think it's worth wondering if the issue is still relevant with modern Webpack. And if so, wouldn't it be better to fix it in Webpack proper ?

At some point, someone needs to break the circle of workaround of workaround of workaround of ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant