Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Volume coupling and nearest projection mapping do not integrate well and are untested #162

Open
3 tasks
BenjaminRodenberg opened this issue Sep 28, 2023 · 0 comments · May be fixed by #163
Open
3 tasks

Volume coupling and nearest projection mapping do not integrate well and are untested #162

BenjaminRodenberg opened this issue Sep 28, 2023 · 0 comments · May be fixed by #163
Assignees
@IshaanDesai
Labels
bug Something isn't working
Milestone
v2.2.0

Comments

@BenjaminRodenberg
Copy link
Member

BenjaminRodenberg commented Sep 28, 2023 •
edited
Loading

The issue precice/tutorials#374 basically originates from a bad integration of volume coupling into the overall code and a lack of testing. I decided to comment out the corresponding code to keep the existing surface coupling features working.

Todos

  • We need some tests that ensure that volume coupling and surface coupling with nearest projection mapping don't conflict
  • We need a proper integration of both features
  • Add channel-transport-reaction as a pure FEniCS case to our tests
@BenjaminRodenberg BenjaminRodenberg added the bug Something isn't working label Sep 28, 2023
@BenjaminRodenberg BenjaminRodenberg changed the title Volume coupling does not integrate well and is untested Volume coupling and nearest projection mapping do not integrate well and are untested Sep 28, 2023
@BenjaminRodenberg BenjaminRodenberg added this to the v2.0.0 milestone Sep 28, 2023
@BenjaminRodenberg BenjaminRodenberg linked a pull request Sep 28, 2023 that will close this issue
Draft
@BenjaminRodenberg BenjaminRodenberg mentioned this issue Jan 15, 2024
Merged
92 tasks
@BenjaminRodenberg BenjaminRodenberg modified the milestones: v2.0.0, v2.x.x Feb 12, 2024
@BenjaminRodenberg BenjaminRodenberg mentioned this issue Feb 12, 2024
Closed
@BenjaminRodenberg BenjaminRodenberg modified the milestones: v2.x.x, v2.1.0, v2.2.0 Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IshaanDesai IshaanDesai

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

WIP: Add tests for volume coupling and fix it precice/fenics-adapter
2 participants
@BenjaminRodenberg @IshaanDesai