Skip to content

Conversation

@pavelzw
Copy link
Contributor

@pavelzw pavelzw commented Dec 25, 2025

Description

with riscv support on conda-forge gaining traction (conda-forge/conda-forge.github.io#1744), we should also support it in rattler-based tooling.

Fixes #{issue}

How Has This Been Tested?

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.

Tools: {e.g., Claude, Codex, GitHub Copilot, ChatGPT, etc.}

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added sufficient tests to cover my changes.
  • I have verified that changes that would impact the JSON schema have been made in schema/model.py.

@pavelzw pavelzw changed the title chore: Build for riscv64gc-unknown-linux-musl chore: Build for riscv64gc Dec 25, 2025
"aarch64-apple-darwin",
"aarch64-unknown-linux-musl",
"aarch64-pc-windows-msvc",
"riscv64gc-unknown-linux-gnu",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did you choose the architecture abbreviation here? Why riscv64gc rather than (say) riscv64?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see from conda/rattler#1949 that you're following rust terminology? Can you add a comment about any/all this in conda-forge/conda-forge.github.io#1744? I'd like to avoid having different names for the same architecture in different places. I'm willing to be convinced that we should follow rust's naming if necessary, but by default I was expecting to use riscv64.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C.f. also conda/conda-build#5884; I'd expect to be able to do

  - if: riscv64
    then:
      - something

in v1 recipes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @h-vetinari, FYI this is a cargo dist configuration file. The target triple is only relevant for the cargo build. Thus this has nothing to do with conda naming things.

@baszalmstra
Copy link
Contributor

@pavelzw What makes this still a draft?

@ruben-arts
Copy link
Contributor

Where you able to test the cargo-dist build locally? It "looks good" but this will fail on releases if it's not done properly.

@ruben-arts
Copy link
Contributor

@pavelzw do you care to add it to the install.sh script so the risc-v users can use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants