-
Notifications
You must be signed in to change notification settings - Fork 415
chore: Build for riscv64gc #5204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| "aarch64-apple-darwin", | ||
| "aarch64-unknown-linux-musl", | ||
| "aarch64-pc-windows-msvc", | ||
| "riscv64gc-unknown-linux-gnu", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how did you choose the architecture abbreviation here? Why riscv64gc rather than (say) riscv64?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see from conda/rattler#1949 that you're following rust terminology? Can you add a comment about any/all this in conda-forge/conda-forge.github.io#1744? I'd like to avoid having different names for the same architecture in different places. I'm willing to be convinced that we should follow rust's naming if necessary, but by default I was expecting to use riscv64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C.f. also conda/conda-build#5884; I'd expect to be able to do
- if: riscv64
then:
- somethingin v1 recipes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @h-vetinari, FYI this is a cargo dist configuration file. The target triple is only relevant for the cargo build. Thus this has nothing to do with conda naming things.
|
@pavelzw What makes this still a draft? |
|
Where you able to test the |
|
@pavelzw do you care to add it to the install.sh script so the risc-v users can use that. |
Description
with riscv support on conda-forge gaining traction (conda-forge/conda-forge.github.io#1744), we should also support it in rattler-based tooling.
Fixes #{issue}
How Has This Been Tested?
AI Disclosure
Tools: {e.g., Claude, Codex, GitHub Copilot, ChatGPT, etc.}
Checklist:
schema/model.py.