-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration filters don't work correctly for postbuildcommands in C# projects #2214
Labels
Comments
Looks like this is the main culprit premake-core/modules/vstudio/vs2005_dotnetbase.lua Lines 236 to 242 in d842e67
I'm guessing that should be looping over each configuration and adding the configuration's condition with something like: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What seems to be the problem?
In the example below, I would expect there to be a PropertyGroup which contains the PostBuildEvent for each configuration. Instead, the generated csproj contains only a single un-filtered PropertyGroup that has the PostBuildEvent for echoing "Debug" and no PropertyGroup that has the PostBuildEvent for echoing "Release".
In contrast, the other properties, such as "symbols" and "optimize", are correctly placed into filtered property groups.
premake.lua
Generated csproj
What did you expect to happen?
I expected to have two separate sets of post build commands that are filtered by each configuration.
What have you tried so far?
I verified that other properties are being filtered correctly, and I verified that this isn't an issue in C++ projects.
How can we reproduce this?
I am generating for VS2022, as follows:
What version of Premake are you using?
Anything else we should know?
Nothing else that I can think of. I looked through existing issues and didn't see one filed for this. Please let me know if there's anything else I can provide to help diagnose the problem. Thank you!
The text was updated successfully, but these errors were encountered: