Skip to content

Commit f5bb038

Browse files
committed
Code review feedback -- remove unused storageTableName
1 parent 97d2603 commit f5bb038

File tree

2 files changed

+2
-11
lines changed

2 files changed

+2
-11
lines changed

presto-analyzer/src/main/java/com/facebook/presto/sql/analyzer/Analysis.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1231,20 +1231,17 @@ public Query getQuery()
12311231
public static final class MaterializedViewInfo
12321232
{
12331233
private final QualifiedObjectName materializedViewName;
1234-
private final QualifiedName storageTableName;
12351234
private final Table dataTable;
12361235
private final Query viewQuery;
12371236
private final MaterializedViewDefinition materializedViewDefinition;
12381237

12391238
public MaterializedViewInfo(
12401239
QualifiedObjectName materializedViewName,
1241-
QualifiedName storageTableName,
12421240
Table dataTable,
12431241
Query viewQuery,
12441242
MaterializedViewDefinition materializedViewDefinition)
12451243
{
12461244
this.materializedViewName = requireNonNull(materializedViewName, "materializedViewName is null");
1247-
this.storageTableName = requireNonNull(storageTableName, "storageTableName is null");
12481245
this.dataTable = requireNonNull(dataTable, "dataTable is null");
12491246
this.viewQuery = requireNonNull(viewQuery, "viewQuery is null");
12501247
this.materializedViewDefinition = requireNonNull(materializedViewDefinition, "materializedViewDefinition is null");
@@ -1255,11 +1252,6 @@ public QualifiedObjectName getMaterializedViewName()
12551252
return materializedViewName;
12561253
}
12571254

1258-
public QualifiedName getStorageTableName()
1259-
{
1260-
return storageTableName;
1261-
}
1262-
12631255
public Table getDataTable()
12641256
{
12651257
return dataTable;

presto-main-base/src/main/java/com/facebook/presto/sql/analyzer/StatementAnalyzer.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2327,15 +2327,14 @@ private Scope processMaterializedView(
23272327
materializedViewDefinition.getOriginalSql(),
23282328
createParsingOptions(session, warningCollector));
23292329

2330-
QualifiedName storageTableName = QualifiedName.of(
2330+
QualifiedName dataTableName = QualifiedName.of(
23312331
materializedViewName.getCatalogName(),
23322332
materializedViewName.getSchemaName(),
23332333
materializedViewDefinition.getTable());
2334-
Table dataTable = new Table(storageTableName);
2334+
Table dataTable = new Table(dataTableName);
23352335

23362336
Analysis.MaterializedViewInfo mvInfo = new Analysis.MaterializedViewInfo(
23372337
materializedViewName,
2338-
storageTableName,
23392338
dataTable,
23402339
viewQuery,
23412340
materializedViewDefinition);

0 commit comments

Comments
 (0)