Skip to content

Post-Full Decompilation Cleanup #40

@WhenGryphonsFly

Description

@WhenGryphonsFly

Once we have reached 100% code decompilation, some cleanup actions will need to be taken.

  • Resolve remaining NONMATCHING and TODO
  • Find and resolve any fakematches that were not labeled TODO
  • Check duplicate code for the possibility of being an inline function
  • Split c files (such as rom_3219C.c)
  • Split h files (such as functions.h and variables.h)
  • Clean up declarations (e.g., use extern and static as appropriate)
    • Deal with overlapping symbols
  • Ensure when setting IO registers that all fields are specified and are specified in the same order (least to most significant bits?)
  • Establish and follow a style guideline in general
  • Ensure overlapping IO registers use the proper register (see sub_24DC)
  • Ensure proper DMA instructions are used (e.g., DmaCopy16 vs DmaCopy32)
  • Remove magic numbers

Data decompilation and symbol documentation are not on this list, as they will still be calculated by calcrom after 100% code decompilation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions