Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abort() should not fire error event #25

Open
mitchlloyd opened this issue Aug 9, 2016 · 1 comment
Open

abort() should not fire error event #25

mitchlloyd opened this issue Aug 9, 2016 · 1 comment

Comments

@mitchlloyd
Copy link

I just noticed that in one of my tests, calling xhr.abort() fires the error event, but this does not happen in Chrome or in Safari (only fires the abort event).

Looking at the tests, it's clear that this is the intended behavior.

The way I'm interpreting the spec, it doesn't appear that abort() should fire the onerror event, but there is definitely some ambiguity I can't quite work though.

https://www.w3.org/TR/XMLHttpRequest/#the-abort()-method

Finally I noticed that this bug appears to have been fixed in sinon's FakeXMLHttpRequest implementation here: sinonjs/sinon#861.

If you agree that this behavior should be changed, let me know and I can create a PR.

@mitchlloyd mitchlloyd changed the title Should abort() fire error event? abort() should not fire error event Aug 9, 2016
@niksy
Copy link

niksy commented Jun 9, 2020

Is this still active?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants