Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-19083] Refactor #397

Merged
merged 73 commits into from
Jan 24, 2025
Merged

[DEV-19083] Refactor #397

merged 73 commits into from
Jan 24, 2025

Conversation

yuriyyakym
Copy link
Contributor

@yuriyyakym yuriyyakym commented Jan 8, 2025

  • I've noticed that we have injectPrezlyMeta, but it's unused and is not even exported. Should I remove it from the package along with normalizePrezlyMetaPlugin?

@yuriyyakym yuriyyakym self-assigned this Jan 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.22148% with 25 lines in your changes missing coverage. Please review.

Project coverage is 85.58%. Comparing base (d9336e8) to head (cc63122).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
- Coverage   90.56%   85.58%   -4.99%     
==========================================
  Files          19       22       +3     
  Lines         265      326      +61     
  Branches       62       84      +22     
==========================================
+ Hits          240      279      +39     
- Misses         24       43      +19     
- Partials        1        4       +3     

@yuriyyakym yuriyyakym changed the title Refactor [DEV-19083] Refactor Jan 21, 2025
@yuriyyakym yuriyyakym marked this pull request as ready for review January 21, 2025 16:19
@yuriyyakym yuriyyakym requested a review from pestaa January 21, 2025 16:19
Copy link
Member

@pestaa pestaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuriyyakym yuriyyakym merged commit 2daaaf0 into main Jan 24, 2025
7 checks passed
@yuriyyakym yuriyyakym deleted the refactor branch January 24, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants