Skip to content

Commit 6dd9242

Browse files
mohammadxalimohammadxali
committed
Flat-ify configurations to support ESLint v9
1 parent 9d4a0db commit 6dd9242

File tree

6 files changed

+219
-181
lines changed

6 files changed

+219
-181
lines changed

‎lib/index.js

+85-83
Original file line numberDiff line numberDiff line change
@@ -1,94 +1,96 @@
11
const importOrderConfig = require("./rule-configs/import-order/base.js");
22
const namingConventionConfig = require("./rule-configs/naming-convention/base.js");
33

4-
module.exports = {
5-
env: {
6-
browser: true,
7-
es2021: true,
8-
node: true,
9-
},
10-
extends: ["airbnb-base", "airbnb-typescript/base", "prettier"],
11-
parser: "@typescript-eslint/parser",
12-
parserOptions: {
13-
ecmaFeatures: {
14-
jsx: true,
4+
module.exports = [
5+
{
6+
files: ["**/*.{ts,tsx,js,jsx,mjs}"],
7+
languageOptions: {
8+
ecmaVersion: 2021,
9+
sourceType: "module",
10+
ecmaFeatures: {
11+
jsx: true,
12+
},
13+
parser: "@typescript-eslint/parser",
14+
parserOptions: {
15+
project: ["./tsconfig.json"],
16+
},
1517
},
16-
ecmaVersion: 12,
17-
sourceType: "module",
18-
project: ["./tsconfig.json"],
19-
},
20-
plugins: [
21-
"@typescript-eslint",
22-
"prettier",
23-
"import",
24-
"sort-export-all",
25-
"deprecation",
26-
],
27-
rules: {
28-
// Prettier handles indent, whitespace and empty lines
29-
"prettier/prettier": 2,
18+
env: {
19+
browser: true,
20+
node: true,
21+
},
22+
plugins: {
23+
"@typescript-eslint": require("@typescript-eslint/eslint-plugin"),
24+
prettier: require("eslint-plugin-prettier"),
25+
import: require("eslint-plugin-import"),
26+
"sort-export-all": require("eslint-plugin-sort-export-all"),
27+
deprecation: require("eslint-plugin-deprecation"),
28+
},
29+
rules: {
30+
// Prettier rules
31+
"prettier/prettier": 2,
3032

31-
// Warn about deprecated methods and properties
32-
"deprecation/deprecation": "warn",
33+
// Warn about deprecated methods and properties
34+
"deprecation/deprecation": "warn",
3335

34-
// Import rules
35-
"sort-export-all/sort-export-all": [
36-
"error",
37-
"asc",
38-
{
39-
caseSensitive: false,
40-
natural: false,
41-
},
42-
],
43-
"import/extensions": [
44-
"error",
45-
"never",
46-
{ svg: "always", json: "always", css: "always", scss: "always" },
47-
],
48-
"import/order": ["error", importOrderConfig],
49-
"import/prefer-default-export": "off",
50-
"import/no-default-export": "error",
51-
"import/no-extraneous-dependencies": "error",
52-
"sort-imports": [
53-
"error",
54-
{
55-
ignoreCase: true,
56-
ignoreDeclarationSort: true,
57-
ignoreMemberSort: false,
58-
memberSyntaxSortOrder: ["none", "all", "multiple", "single"],
59-
},
60-
],
36+
// Import rules
37+
"sort-export-all/sort-export-all": [
38+
"error",
39+
"asc",
40+
{
41+
caseSensitive: false,
42+
natural: false,
43+
},
44+
],
45+
"import/extensions": [
46+
"error",
47+
"never",
48+
{ svg: "always", json: "always", css: "always", scss: "always" },
49+
],
50+
"import/order": ["error", importOrderConfig],
51+
"import/prefer-default-export": "off",
52+
"import/no-default-export": "error",
53+
"import/no-extraneous-dependencies": "error",
54+
"sort-imports": [
55+
"error",
56+
{
57+
ignoreCase: true,
58+
ignoreDeclarationSort: true,
59+
ignoreMemberSort: false,
60+
memberSyntaxSortOrder: ["none", "all", "multiple", "single"],
61+
},
62+
],
6163

62-
// General code-style rules
63-
"@typescript-eslint/naming-convention": namingConventionConfig,
64-
"id-blacklist": [
65-
2,
66-
"arr",
67-
"cb",
68-
"e",
69-
"el",
70-
"err",
71-
"idx",
72-
"num",
73-
"str",
74-
"tmp",
75-
"val",
76-
],
77-
"no-return-assign": ["error", "except-parens"],
78-
"no-unused-vars": "off",
79-
"@typescript-eslint/no-unused-vars": [
80-
"error",
81-
{ argsIgnorePattern: "^_", ignoreRestSiblings: true },
82-
],
83-
"@typescript-eslint/consistent-type-imports": "error",
84-
"@typescript-eslint/no-import-type-side-effects": "error",
64+
// General code-style rules
65+
"@typescript-eslint/naming-convention": namingConventionConfig,
66+
"id-blacklist": [
67+
2,
68+
"arr",
69+
"cb",
70+
"e",
71+
"el",
72+
"err",
73+
"idx",
74+
"num",
75+
"str",
76+
"tmp",
77+
"val",
78+
],
79+
"no-return-assign": ["error", "except-parens"],
80+
"no-unused-vars": "off",
81+
"@typescript-eslint/no-unused-vars": [
82+
"error",
83+
{ argsIgnorePattern: "^_", ignoreRestSiblings: true },
84+
],
85+
"@typescript-eslint/consistent-type-imports": "error",
86+
"@typescript-eslint/no-import-type-side-effects": "error",
8587

86-
"prefer-destructuring": "warn",
87-
"no-nested-ternary": "warn",
88+
"prefer-destructuring": "warn",
89+
"no-nested-ternary": "warn",
8890

89-
"func-style": ["error", "declaration"],
91+
"func-style": ["error", "declaration"],
9092

91-
// Extra rules
92-
radix: "off",
93+
radix: "off",
94+
},
9395
},
94-
};
96+
];

‎lib/nextjs-tailwind.js

+9-7
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
const importOrderConfig = require("./rule-configs/import-order/next.js");
21
const namingConventionConfig = require("./rule-configs/naming-convention/next-tailwind.js");
2+
const nextJsConfig = require("./nextjs.js");
33

4-
module.exports = {
5-
extends: [require.resolve("./nextjs.js")],
6-
rules: {
7-
// General code-style rules
8-
"@typescript-eslint/naming-convention": namingConventionConfig,
4+
module.exports = [
5+
...nextJsConfig,
6+
{
7+
files: ["**/*.{ts,tsx,js,jsx}"],
8+
rules: {
9+
"@typescript-eslint/naming-convention": namingConventionConfig,
10+
},
911
},
10-
};
12+
];

‎lib/nextjs.js

+55-38
Original file line numberDiff line numberDiff line change
@@ -1,46 +1,63 @@
11
const importOrderConfig = require("./rule-configs/import-order/next.js");
22
const namingConventionConfig = require("./rule-configs/naming-convention/next.js");
3+
const reactConfig = require("./react.js");
34

4-
module.exports = {
5-
extends: [require.resolve("./react.js"), "next/core-web-vitals"],
6-
rules: {
7-
"import/order": ["error", importOrderConfig],
5+
module.exports = [
6+
...reactConfig,
7+
{
8+
files: ["**/*.{ts,tsx,js,jsx}"],
9+
plugins: {
10+
"@typescript-eslint": require("@typescript-eslint/eslint-plugin"),
11+
prettier: require("eslint-plugin-prettier"),
12+
import: require("eslint-plugin-import"),
13+
react: require("eslint-plugin-react"),
14+
},
15+
languageOptions: {
16+
parser: "@typescript-eslint/parser",
17+
parserOptions: {
18+
ecmaFeatures: {
19+
jsx: true,
20+
},
21+
project: ["./tsconfig.json"],
22+
},
23+
},
24+
rules: {
25+
// Import order rules
26+
"import/order": ["error", importOrderConfig],
827

9-
// General code-style rules
10-
"@typescript-eslint/naming-convention": namingConventionConfig,
28+
// General code-style rules
29+
"@typescript-eslint/naming-convention": namingConventionConfig,
1130

12-
// Allow prop spreading for `react-intl` FormattedMessage component
13-
"react/jsx-props-no-spreading": [
14-
"error",
15-
{
16-
exceptions: ["FormattedMessage"],
17-
},
18-
],
31+
// Allow prop spreading for `react-intl` FormattedMessage component
32+
"react/jsx-props-no-spreading": [
33+
"error",
34+
{
35+
exceptions: ["FormattedMessage"],
36+
},
37+
],
38+
},
1939
},
20-
overrides: [
21-
{
22-
files: ["pages/**"],
23-
rules: {
24-
// Next.js needs default exports for pages and API points
25-
"import/no-default-export": "off",
26-
// Next.js `getServerSideProps` has a quite complex type, so it's safer to define it as a const
27-
// and have the `GetServerSideProps<P>` type applied to it for better type safety
28-
"func-style": [
29-
"error",
30-
"declaration",
31-
{ allowArrowFunctions: true },
32-
],
33-
},
40+
41+
// Overrides for specific file patterns
42+
{
43+
files: ["pages/**"],
44+
rules: {
45+
// Allow default exports for Next.js pages and API routes
46+
"import/no-default-export": "off",
47+
// Allow arrow functions for Next.js `getServerSideProps`
48+
"func-style": [
49+
"error",
50+
"declaration",
51+
{ allowArrowFunctions: true },
52+
],
3453
},
35-
{
36-
files: ["modules/**"],
37-
rules: {
38-
// TODO: NextJS Dynamic import doesn't work too well with named exports.
39-
// Gotta figure out how to make them work together.
40-
// Some hints here: https://github.com/vercel/next.js/issues/22278#issuecomment-1009865850
41-
"import/no-default-export": "off",
42-
"no-restricted-exports": "off",
43-
},
54+
},
55+
{
56+
files: ["modules/**"],
57+
rules: {
58+
// Allow default exports for Next.js dynamic imports
59+
"import/no-default-export": "off",
60+
"no-restricted-exports": "off",
4461
},
45-
],
46-
};
62+
},
63+
];

‎lib/prettier.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -7,34 +7,34 @@ module.exports = {
77

88
overrides: [
99
{
10-
files: ["*.json"],
10+
files: "*.json",
1111
options: {
1212
parser: "json",
1313
tabWidth: 2,
1414
singleQuote: false,
1515
},
1616
},
1717
{
18-
files: ["*.yml"],
18+
files: "*.yml",
1919
options: {
20-
parser: "yml",
20+
parser: "yaml",
2121
tabWidth: 2,
2222
singleQuote: false,
2323
},
2424
},
2525
{
26-
files: ["*.css"],
26+
files: "*.css",
2727
options: {
2828
parser: "css",
2929
singleQuote: false,
3030
},
3131
},
3232
{
33-
files: ["*.scss"],
33+
files: "*.scss",
3434
options: {
3535
parser: "scss",
3636
singleQuote: false,
3737
},
3838
},
3939
],
40-
};
40+
};

0 commit comments

Comments
 (0)