Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup Original/Ogushi/FiFA layout algorithms #42

Open
masuhar opened this issue Jul 9, 2022 · 0 comments
Open

cleanup Original/Ogushi/FiFA layout algorithms #42

masuhar opened this issue Jul 9, 2022 · 0 comments

Comments

@masuhar
Copy link
Contributor

masuhar commented Jul 9, 2022

In the source code, there are at least three files that implement layout algorithms (....write the file names here...). Those algorithms should be able to be selected via the Preferences dialog.

  1. Currently, the dialog works but we don't understand why.
  2. Currently, the dialog can choose either FiFA or Original, but some other algorithms might also be selected.
  3. Currently, the implementation seems to use if (selecet == "FiFA") do something else do something eles ... style, which is not so modular. Use classes or other module mechanism.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant