Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat #6772 : defaultVisible prop added #6770

Closed
wants to merge 7 commits into from
Closed

feat #6772 : defaultVisible prop added #6770

wants to merge 7 commits into from

Conversation

jpranays
Copy link
Contributor

@jpranays jpranays commented Jun 19, 2024 •
edited by melloware
Loading

defaultVisible Prop to Dialog Component

Fix #6772

This pull request introduces a new defaultVisible prop to the Dialog component in our UI library. The defaultVisible prop allows developers to control the initial visibility of the Dialog when the component mounts.

Description

The defaultVisible prop is a boolean that, when set to true, ensures that the Dialog is displayed immediately upon mounting. Conversely, setting this prop to false or omitting it entirely will maintain the default behavior, where the Dialog is hidden initially and requires a trigger to become visible.

Changes

  • Added defaultVisible prop to the Dialog component's API.
  • Updated the Dialog component's internal state management to account for the defaultVisible prop.
  • Ensured backward compatibility by defaulting the defaultVisible prop to false.

Usage

<Dialog defaultVisible={true}>
    <!-- Dialog content goes here -->
</Dialog>

@vercel Vercel
Copy link

vercel bot commented Jun 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2024 0:02am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Jul 2, 2024 0:02am

@github-actions GitHub Actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware melloware added Status: Pending Review Issue or pull request is being reviewed by Core Team Status: Discussion Issue or pull request needs to be discussed by Core Team labels Jun 19, 2024
@jpranays jpranays changed the title feat: defaultVisible prop added feat #6772 : defaultVisible prop added Jun 19, 2024
@jpranays
Copy link
Contributor Author

Any update on this ?

@melloware
Copy link
Member

Any update on this ?

It is assigned to PrimeTek for their review.

@nitrogenous
Copy link
Contributor

Thank you for bringing this issue to our attention and for your valuable contribution. We truly appreciate the effort you put into this pull request.

However, after careful consideration, we have decided to reject the pull request. Our decision is based on the need to maintain synchronization across multiple UI libraries that we are currently developing. Additionally, we believe that this feature might lead to confusion among other users.

We hope you understand our decision, and we look forward to any future contributions you may have.

@jpranays

@nitrogenous nitrogenous closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware requested changes

Assignees

@nitrogenous nitrogenous

@gucal gucal

Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dialog: Add defaultVisible property
4 participants
@jpranays @melloware @nitrogenous @gucal