You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We don't have an easily repeatable pattern for clearing filters across the site, which leaves people to create a custom solution when needed. It may be worth coming up with a consistent pattern here.
I think it might be worth including Filters/Clear Filters patterns in the design guidelines to help inform future design decisions.
Screenshots
PRs and Issues
File Diffs - Clear File Filters (Old)
File Diffs - Clear File Filters (Updated)**
Thoughts & Q's
how do we make it clear that filters have been selected if we're not using an input or any other indication that filters are being applied (like in the PRs/Issues pattern). For example, it's not that obvious that filters are applied the second image, the only difference is that the link changes to blue:
👇 no filters selected/applied 👇
👇 commit and file filters applied 👇
The text was updated successfully, but these errors were encountered:
This came up in response to: https://github.com/github/github/pull/107687
(also https://github.com/github/github/issues/106809)
Problem & Goal
We don't have an easily repeatable pattern for clearing filters across the site, which leaves people to create a custom solution when needed. It may be worth coming up with a consistent pattern here.
I think it might be worth including Filters/Clear Filters patterns in the design guidelines to help inform future design decisions.
Screenshots
PRs and Issues
![screenshot 2019-02-14 09 32 57](https://user-images.githubusercontent.com/586552/52793755-66a87d80-303c-11e9-936a-06b44d4bebfe.png)
File Diffs - Clear File Filters (Old)
![screenshot 2019-02-14 09 40 48](https://user-images.githubusercontent.com/586552/52793834-a2434780-303c-11e9-8fe4-2543199b7c05.png)
File Diffs - Clear File Filters (Updated)**
![screenshot 2019-02-14 09 41 24](https://user-images.githubusercontent.com/586552/52793876-b5eeae00-303c-11e9-9c75-fafa0dc97e77.png)
Thoughts & Q's
👇 no filters selected/applied 👇
![screenshot 2019-02-14 09 54 46](https://user-images.githubusercontent.com/586552/52794833-96588500-303e-11e9-88a2-9f41f34d2fb5.png)
👇 commit and file filters applied 👇
![screenshot 2019-02-14 09 54 42](https://user-images.githubusercontent.com/586552/52794835-96588500-303e-11e9-8394-d54a6337749c.png)
The text was updated successfully, but these errors were encountered: