Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters & Clearing Filters #29

Open
emilybrick opened this issue Feb 14, 2019 · 0 comments
Open

Filters & Clearing Filters #29

emilybrick opened this issue Feb 14, 2019 · 0 comments

Comments

@emilybrick
Copy link
Contributor

emilybrick commented Feb 14, 2019

This came up in response to: https://github.com/github/github/pull/107687
(also https://github.com/github/github/issues/106809)

Problem & Goal

We don't have an easily repeatable pattern for clearing filters across the site, which leaves people to create a custom solution when needed. It may be worth coming up with a consistent pattern here.

I think it might be worth including Filters/Clear Filters patterns in the design guidelines to help inform future design decisions.

Screenshots

PRs and Issues
screenshot 2019-02-14 09 32 57

File Diffs - Clear File Filters (Old)
screenshot 2019-02-14 09 40 48

File Diffs - Clear File Filters (Updated)**
screenshot 2019-02-14 09 41 24


Thoughts & Q's

  • how do we make it clear that filters have been selected if we're not using an input or any other indication that filters are being applied (like in the PRs/Issues pattern). For example, it's not that obvious that filters are applied the second image, the only difference is that the link changes to blue:

👇 no filters selected/applied 👇
screenshot 2019-02-14 09 54 46

👇 commit and file filters applied 👇
screenshot 2019-02-14 09 54 42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants