Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading state on NavList items #599

Closed
mperrotti opened this issue Sep 19, 2023 · 1 comment
Closed

Support loading state on NavList items #599

mperrotti opened this issue Sep 19, 2023 · 1 comment

Comments

@mperrotti
Copy link
Contributor

This change is based on the patterns documented in #590

Sometimes NavList items have to wait for data to render correctly. For example, if the URL is dynamic, or if we want to make sure the linked view can be loaded before letting users click it.

Since NavList uses ActionList under the hood, we may want to make the change in ActionList and open up the NavList API to support a loading state.

Example

The right side sheet navigation for logged in users on GitHub with some of the navigation items in a loading state

@mperrotti
Copy link
Contributor Author

Filed in wrong repo

@mperrotti mperrotti closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant